Skip to content

Replace black with ruff for code formatting #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
norkans7 merged 1 commit into from
Mar 24, 2026
Merged

Replace black with ruff for code formatting #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Initialize environment
run: uv sync --locked --all-groups

- name: Run black
- name: Run ruff format check
run: uv run ruff format --check temba_client

- name: Run ruff
Expand Down
5 changes: 1 addition & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ include = ["temba_client"]
requires = ["hatchling"]
build-backend = "hatchling.build"

[tool.black]
line-length = 119

[tool.ruff]
line-length = 120
Comment on lines 42 to 43
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[tool.ruff] is configured with line-length = 120, but isort is still configured with line_length = 119 (see the [tool.isort] section further down in this file). Now that formatting is handled by Ruff, these mismatched line-length settings can lead to inconsistent wrapping behavior across tools; it’s best to align on a single value (e.g., set both to 120, or keep both at 119 to preserve existing formatting).

Copilot uses AI. Check for mistakes.
fix = true
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix = true makes ruff check run in fix mode by default. Since CI runs ruff check temba_client without --no-fix, this can cause the linter step to mutate files in CI (and potentially mask issues depending on exit-code behavior). Consider setting fix = false in config and enabling fixes only in local/dev commands, or add --no-fix in CI (and optionally --exit-non-zero-on-fix where fixes are allowed).

Suggested change
fix = true
fix = false

Copilot uses AI. Check for mistakes.
Expand All @@ -53,7 +50,7 @@ ignore = ["E501", "F405"]
[tool.isort]
multi_line_output = 3
force_grid_wrap = 0
line_length = 119
line_length = 120
include_trailing_comma = true
combine_as_imports = true
sections = ["FUTURE", "STDLIB", "THIRDPARTY", "FIRSTPARTY", "LOCALFOLDER"]
Loading