[main] Global settings - #1480
Conversation
77ac790 to
deaaadf
Compare
|
Hi @joshmeranda Today I ran into an issue with the webhook which this PR may be involved in. On the rancher side I see rancher startup failing with
In the webhook log the last entry seen is
I.e. creation of the With extended logging in my local webhook I see
Emphasis on the Value and Default fields here is mine. I.e. the webhook is given a setting with a Default, but not a Value. This matches the error message reported by r/r: The definition of the setting, i.e.
in r/r seems to have its last change done 4 years ago. I.e. unlikely to have caused this. My setup used r/r commit 1952e0e987242f0f2ca73799df7f1af9729ded72 (main at the time I am writing this) |
|
@andreas-kupries I wasn't able to reproduce but I see the where the issue lies. I think validation error slips through the cracks because the setting is being created before webhook up. |
|
I am using a local webhook for work of my own, and the created setting definitely reaches the setting validator in the webhook, where it is then rejected. Per my logs. |
|
Fair enough, I have a fix... just fighting with github outages to get the fix up\ |
Issue:
Problem
Not all validations performed by norman on rancher settings are done by steve.
Solution
Added additional validations for rancher settings crds.d
CheckList