Skip to content

Update very old docker client - #255

Open
Sarke wants to merge 2 commits into
rancher:masterfrom
Sarke:sarke-update-docker-client
Open

Update very old docker client#255
Sarke wants to merge 2 commits into
rancher:masterfrom
Sarke:sarke-update-docker-client

Conversation

@Sarke

@Sarke Sarke commented Jul 23, 2024

Copy link
Copy Markdown

The old docker client (https://github.com/samalba/dockerclient/) is 8 years old and archived, and was causing error on newer versions of Docker:

Unable to query docker version: 400 Bad Request: client version 1.15 is too old. Minimum supported API version is 1.24, please upgrade your client to a newer version

@Sarke

Sarke commented Jul 24, 2024

Copy link
Copy Markdown
Author

Sorry, the pull request became a bit noisy with the io/ioutil deprecations. Main point of the PR is 6a9b71d

@NCC-IP

NCC-IP commented Oct 17, 2024

Copy link
Copy Markdown

@Sarke Looks like io/ioutil has been replaced/refactored in master (158b336). This will need rebased by the looks, as is now conflicting. Should tidy the PR up though!

It'd be really good to see this picked up and reviewed by one of the maintainers, the client not supported error makes me sad :P Maybe @jiaqiluo could have a look, if it fits with their tasking <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants