Skip to content

Allow cloud-config to Work on Distros with Read-Only /usr Partitions #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justdan96 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow cloud-config to Work on Distros with Read-Only /usr Partitions #253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e3fc25
allow cloud-config to work on distros with read-only /usr partitions …
justdan96 Jun 28, 2024
080ca04
remove detection logic
justdan96 Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion commands/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,8 @@ func updateUserdataFile(driverOpts *rpcdriver.RPCFlags, machineName, hostname, u
// on how hostnames are set in cloud-config (userdata)
func writeCloudConfig(machineName, encodedData, machineOS, hostname string, cf map[interface{}]interface{}, newUserDataFile *os.File) error {
command := "sh"
path := "/usr/local/custom_script/install.sh"
// allow the script to work on distros with read-only /usr partitions
path := "/var/run/install.sh"

@jakefhyde jakefhyde Sep 27, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
path := "/var/run/install.sh"
path := "/opt/rancher-system-agent/install.sh"

I believe we install the system agent within that directory anyway if /usr is not writable, so I'd rather reuse that if possible.

@justdan96 justdan96 Oct 1, 2024

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That path wouldn't exist on the machine initially. /var/run is the most portable path that could be used, since it will definitely exist and will always be writable.

@justdan96 justdan96 Dec 6, 2024

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakefhyde are you happy with the PR as-is?

key := "hostname"
if strings.Contains(machineOS, "windows") {
// the writeFile path should ideally be C:\usr\local\custom_script\install.ps1
Expand Down