Added ability to disable network security groups and availability sets/zone - #210
Open
jk-f5 wants to merge 3 commits into
Open
Added ability to disable network security groups and availability sets/zone#210jk-f5 wants to merge 3 commits into
jk-f5 wants to merge 3 commits into
Conversation
jiaqiluo
requested changes
Aug 2, 2023
Co-authored-by: Jiaqi Luo <6218999+jiaqiluo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use rancher-machine in our Gitlab runners to run CI jobs. Network security groups and availability sets/zone are unneeded overhead for our purposes.
This PR adds the ability to disable them.
Also we'd like to see #203 added back (which is how docker-machine originally behaved and was reverted in #208). Having debug logs go to stdout is problematic for our use case. We're currently maintaining a fork with that patch.