Skip to content

Handle missing __has_builtin correctly #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelChirico merged 2 commits into from
Aug 25, 2026
Merged

Handle missing __has_builtin correctly #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0abf3c4
Gemini: handle systems where __has_builtin is missing e.g. GCC < 10
MichaelChirico Aug 24, 2026
5793306
fine-tune NEWS
MichaelChirico Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@

1. Supplying `keep.names=` to `as.integer64()` now emits a warning, which will become an error in the next release.

## BUG FIXES

1. Fixed handling of `__has_builtin` preprocessor macro where it's absent (e.g. GCC < 10; #388).

## NOTES

1. The R version dependency has been bumped from 3.5.0 (2018) to 3.6.0 (2019).
Expand Down
6 changes: 5 additions & 1 deletion src/integer64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ static inline bool is_na64(long long x) {
#define BITSTRING_OVERFLOW_WARNING "bitstrings longer than 64 bytes converted to NA, multibyte-characters not allowed"
#define INTEGER64_NA_COERCION_WARNING "NAs introduced by coercion to integer64 range"

#if (defined(__GNUC__) && __GNUC__ >= 5) || (defined(__has_builtin) && __has_builtin(__builtin_add_overflow))
#ifndef __has_builtin
#define __has_builtin(x) 0
#endif

#if (defined(__GNUC__) && __GNUC__ >= 5) || __has_builtin(__builtin_add_overflow)
#define HAVE_BUILTIN_OVERFLOW 1
#endif

Expand Down
Loading