Repository navigation
Conversation
Use DoNothingCombiner when for_each_no_score materializes a specialized multi-term union. Preserve the existing buffered traversal while avoiding the configured combiner's score updates. Exercise BooleanWeight dispatch with frequency-reading term weights and a combiner that panics on scoring. Verify the union's ordered, deduplicated document IDs.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
PSeitz
marked this pull request as draft
October 28, 2026 16:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BooleanWeight::for_each_no_scoreinitially builds its scorer withDoNothingCombiner, but its specialized multi-term union branch then builds a buffered union with the configured scoring combiner. This can perform score updates during document-only traversal.Use
DoNothingCombinerfor that buffered union too. The existing dispatch and buffered traversal remain unchanged.Add a regression through
BooleanWeight::for_each_no_scoreusing frequency-reading term weights to reach the specialized dispatch and a custom combiner that panics on score updates or score retrieval. It also checks ordered, deduplicated document IDs, including documents matching both terms.Validation
cargo test --lib test_for_each_no_score_term_union_skips_scoringpasses after the fix.cargo test --lib: 1,344 passed, 8 ignored.cargo +nightly fmt --allgit diff --checkDisclosure
Implemented and tested with AI assistance.