Jaegerv2 #6023
Open
Jaegerv2 #6023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
Dec 16, 2025
fulmicoton
reviewed
Dec 17, 2025
fulmicoton
reviewed
Dec 17, 2025
|
|
||
| if root_only { | ||
| let is_root = UserInputQuery { | ||
| user_text: "NOT is_root:false".to_string(), |
Collaborator
There was a problem hiding this comment.
why not is_root:true ? Why not a term query? Is this in v1?
Contributor
Author
There was a problem hiding this comment.
https://github.com/quickwit-oss/quickwit/blob/main/quickwit/quickwit-jaeger/src/lib.rs#L322 same in v1 implementation
I don't think a term query is appropriate because, if I understand correctly, a term query searches for fields where is_root is false, or in cases where there are child spans, the field does not exist
fulmicoton
reviewed
Dec 17, 2025
| default_operator: BooleanOperand::And, | ||
| lenient: true, | ||
| }; | ||
| let mut new_query = BoolQuery::default(); |
Collaborator
There was a problem hiding this comment.
nitpick: BooleanQuery::intersection
Contributor
Author
There was a problem hiding this comment.
I can't find the BoolQuery::intersection method, are you sure it exists?
fulmicoton
requested changes
Dec 17, 2025
Collaborator
fulmicoton
left a comment
fulmicoton
left a comment
There was a problem hiding this comment.
A couple of nitpicks here and there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jaeger has a new specification for the GRPC remote storage API. They have removed the old version from release 2.6 onwards
https://github.com/jaegertracing/jaeger/tree/v2.13.0/internal/storage/v2/grpc
How was this PR tested?
I add unit test for grpc endpoint and new helper function. And I tested the features with the latest version of Jaeger, and everything works fine.