feat: Making expected SQL annotations more descriptive and repeatable#225
Closed
nagyesta wants to merge 2 commits intoquick-perf:masterfrom
Closed
feat: Making expected SQL annotations more descriptive and repeatable#225nagyesta wants to merge 2 commits intoquick-perf:masterfrom
nagyesta wants to merge 2 commits intoquick-perf:masterfrom
Conversation
Contributor
Author
|
Must be merged after #224 |
nagyesta
force-pushed
the
222-making-expected-sql-annotations-more-descriptive
branch
from
c882dc6 to
13974cf
Compare
- Add new repeated ExpectSelect/ExpectInsert/ExpectUpdate/ExpectDelete annotation variants - Include optional comment in ExpectSelect/ExpectInsert/ExpectUpdate/ExpectDelete - Add and register new verifiers - Add new test cases Resolves quick-perf#222 Signed-off-by: Esta Nagy <[email protected]>
nagyesta
force-pushed
the
222-making-expected-sql-annotations-more-descriptive
branch
from
13974cf to
a1a9c40
Compare
- Add optional comment to ExpectJdbcQueryExecution Resolves quick-perf#222 Signed-off-by: Esta Nagy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #222