Add linked token resolution#9
Conversation
This allows to pass the linked token without changing function signatures.
It can be retrieved with (*http.Request).Context().Value(websspi.LinkedTokenUserInfoKey).
|
Thanks, at first glance it looks good. Thanks for your effort! Will have more time to look it more detailed during the weekend. Noticed a buffer holding the SID is allocated with 50 bytes. May be it would be reasonable to preserve 68 bytes just for the SID as that seems to be the maximum byte size of a user SID. |
quasoft
left a comment
quasoft
left a comment
There was a problem hiding this comment.
May be we should extend a bit the comment in the doc.go file. Something like that should do:
websspi package implements a middleware for SSO Kerberos authentication of HTTP requests in Windows environments by SSPI, without the need for any keytab files
| @@ -0,0 +1,4 @@ | |||
| /* | |||
| Package websspi provides middleware to require with Windows Integrated Authentication. | |||
There was a problem hiding this comment.
May be we should extend a bit the comment in the doc.go file. Something like that should do:
| Package websspi provides middleware to require with Windows Integrated Authentication. | |
| Package websspi implements a middleware for SSO Kerberos authentication of HTTP requests in Windows environments by SSPI, without the need for any keytab files |
| &usedMemory, | ||
| ) | ||
|
|
||
| tokenuser := (*TokenUser)(unsafe.Pointer(&buffer[0])) |
There was a problem hiding this comment.
It doesn't really matter, but we could first check the value of err, before setting the value of the tokenuser variable
| if a.Config.ServerName == "" { | ||
| u.Groups, err = a.GetGroupsFromToken(linkedToken) | ||
| } else { | ||
| u.Groups, err = a.GetUserGroups(u.Username) |
There was a problem hiding this comment.
Not sure about this, but if u.Username is same for both the original Token and the LinkedToken, there won't be need to check for the direct groups again.
GetLinkedUserInfo is a new function, and if we agree that it does not need to be backwards compatible, you can make it completely ignore Config.ServerName value.
2 participants
By setting
(websspi.Config).ResolveLinkedthere will be another*websspi.UserInfoplaced in the request context with the keywebsspi.LinkedTokenUserInfoKey.The example is extended to return both, the regular and linked token (emphasis is not in the example):
If the same site is requested from an elevated command, the tokens are swapped. Tests and improved documentation is missing, hence the draft status of this PR.
Closes #5.