abootimg: Fix gzip decompressed kernel size passed to load_image() - #15
Merged
Merged
Conversation
gzip_decompress() was discarding the out_consumed return value from miniz_oxide's decompress(), leaving FastbootBuffer::len set to the full 128 MiB allocation. load_image() then passed that oversized buffer to UEFI's LoadImage, causing it to fail with LOAD_ERROR since the trailing zeroes don't constitute a valid PE image. Fix by returning out_consumed from gzip_decompress() and updating kernel.len to the actual decompressed size before calling load_image(). It fixes the failure below seen on qcs9100-ride when booting Image.gz built into abootimg. Dev_Common_Speed: Dev Bus Speed: Super, state 2 Allocated E18000 bytes Response: DATA00E18000 (12) Response: OKAY (4) kernel: 0xBA5780@0x1000 ramdisk: 0x240224@0xBA7000 dtb: 0x2FBDC@0xDE8000 ERROR: Encountered NULL ImageContext Error: Failed to load kernel image Fixes: 87a7388 ("abootimg: Implement decompress") Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
Contributor
Hm, interesting.. I've been running GZ-compressed kernels for quite a while and haven't seen this issue. May it be that I just got lucky.. Do you have CONFIG_EFI(_STUB)=y? |
Author
Yes, I have the options. |
Contributor
|
FWIW the PR looks good, but for reference could you do Here's one that didn't: |
Author
|
Here is the one that failed. |
Contributor
|
I don't know for sure and I don't really want to spend more time digging, but.. I would guesstimate that my image having the section table (starts with seems like that's a combination of CONFIG_EFI_DEBUG=n and CONFIG_ARM64_BTI_KERNEL=y that makes it be aligned like this |
quic-kdybcio
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gzip_decompress() was discarding the out_consumed return value from miniz_oxide's decompress(), leaving FastbootBuffer::len set to the full 128 MiB allocation. load_image() then passed that oversized buffer to UEFI's LoadImage, causing it to fail with LOAD_ERROR since the trailing zeroes don't constitute a valid PE image.
Fix by returning out_consumed from gzip_decompress() and updating kernel.len to the actual decompressed size before calling load_image().
It fixes the failure below seen on qcs9100-ride when booting Image.gz built into abootimg.
Dev_Common_Speed: Dev Bus Speed: Super, state 2
Allocated E18000 bytes
Response: DATA00E18000 (12)
Response: OKAY (4)
kernel: 0xBA5780@0x1000
ramdisk: 0x240224@0xBA7000
dtb: 0x2FBDC@0xDE8000
ERROR: Encountered NULL ImageContext
Error: Failed to load kernel image
Fixes: 87a7388 ("abootimg: Implement decompress")