gstreamer1.0-plugins-good: Add patches for pulsedirectsink - #2821
Conversation
Test Results 117 files 698 suites 9h 16m 51s ⏱️ For more details on these failures, see this check. Results for commit 2872169. ♻️ This comment has been updated with latest results. |
| Date: Tue, 28 Jul 2026 14:42:05 +0530 | ||
| Subject: [PATCH] pulse: NULL check before de-reference | ||
|
|
||
| Upstream-Status: Submitted [upstream ticket <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/12144>] |
There was a problem hiding this comment.
It's not a ticket.
| since PulseAudio does not rate-limit an encoded passthrough stream via | ||
| writable-size flow control. | ||
|
|
||
| Upstream-Status: Submitted [upstream ticket <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/12144>] |
There was a problem hiding this comment.
Neither is this
| file://0007-v4l2-Drop-empty-bytesused-0-buffers.patch \ | ||
| file://0008-v4l2-Handle-GAP-buffer-in-encoder.patch \ | ||
| file://0010-v4l2-Add-support-for-V4L2_PIX_FMT_QC10C-format.patch \ | ||
| file://0011-pulse-NULL-check-before-de-reference.patch \ |
There was a problem hiding this comment.
Why are we importing the patches to this layer?
There was a problem hiding this comment.
The upstream review is pending and there is no timeline when or whether this is going to be merged in upstream.
We want to have this feature available in the mainline builds.
There was a problem hiding this comment.
This plugin is used to expose a SOC capability which is compress offload (where audio decode + playback happens on the DSP). So it is related to the BSP.
Add a new PulseAudio sink built directly on GstBaseSink rather than GstAudioBaseSink, using the PulseAudio extended-stream API (pa_stream_new_extended / pa_format_info). Unlike pulsesink, which is oriented around a PCM ringbuffer, pulsedirectsink writes encoded frames straight to the server, making it suitable for DSP offload where the sink, not the CPU, performs playout. These patches have been submitted for upstream review. - pulse: NULL check before de-reference - pulse: add pulsedirectsink element Signed-off-by: Bala Sai Kosuri <bkosuri@qti.qualcomm.com>
5 participants
Add a new PulseAudio sink built directly on GstBaseSink rather than GstAudioBaseSink, using the PulseAudio extended-stream API (pa_stream_new_extended / pa_format_info). Unlike pulsesink, which is oriented around a PCM ringbuffer, pulsedirectsink writes encoded frames straight to the server, making it suitable for DSP offload where the sink, not the CPU, performs playout.
These patches have been submitted for upstream review.