Skip to content

release: v1.25.1 WorkerBus reliability patch - #308

Closed
qnbs wants to merge 3 commits into
mainfrom
release/v1.25.1
Closed

release: v1.25.1 WorkerBus reliability patch#308
qnbs wants to merge 3 commits into
mainfrom
release/v1.25.1

Conversation

@qnbs

@qnbs qnbs commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

Local verification

  • pnpm run lint
  • pnpm run typecheck
  • pnpm run i18n:check (19 locales, 2,869 keys)
  • pnpm run parity:check
  • pnpm run docs:check
  • pnpm run suppressions:check (52/52)
  • pnpm run token:audit (160/160)

Release gate

  • Full PR CI green
  • Tauri branch build reaches Finished N bundles on Ubuntu and macOS
  • Zero unresolved review threads
  • Squash-merge, verify main CI, then push signed v1.25.1 tag
  • Verify GitHub Release assets, signatures, and latest.json

Copilot AI review requested due to automatic review settings August 1, 2026 16:18
@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
worldscript-studio Ready Ready Preview Aug 1, 2026 4:29pm

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 41 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 697d10b5-a475-4b42-a194-2fbf8f08f5fc

📥 Commits

Reviewing files that changed from the base of the PR and between b4bfd7a and 805a041.

⛔ Files ignored due to path filters (1)
  • src-tauri/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (9)
  • .github/SECURITY.md
  • AGENTS.md
  • AUDIT.md
  • CHANGELOG.md
  • README.md
  • package.json
  • public/sw.js
  • src-tauri/Cargo.toml
  • src-tauri/tauri.conf.json

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Aug 1, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in b4bfd7a...805a041 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Docker Aug 1, 2026 4:28p.m. Review ↗
JavaScript Aug 1, 2026 4:28p.m. Review ↗
Python Aug 1, 2026 4:28p.m. Review ↗
Rust Aug 1, 2026 4:28p.m. Review ↗
Shell Aug 1, 2026 4:28p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@qnbs

qnbs commented Aug 1, 2026

Copy link
Copy Markdown
Owner Author

@CodeAnt-AI review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prepares the v1.25.1 reliability release by synchronizing release metadata and documenting WorkerBus and desktop-notification changes.

Changes:

  • Bumps web, PWA, Tauri, and documentation versions to 1.25.1.
  • Adds dated release notes for PRs #305#307.
  • Updates the supported-version policy.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Bumps the web package version.
public/sw.js Updates the service-worker cache version.
src-tauri/Cargo.toml Bumps the Rust package version.
src-tauri/Cargo.lock Synchronizes the locked application version.
src-tauri/tauri.conf.json Bumps the Tauri application version.
README.md Updates the release badge.
AGENTS.md Updates the documented project version.
.github/SECURITY.md Updates supported release ranges.
CHANGELOG.md Adds v1.25.1 release notes.

Comment thread AGENTS.md Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c4b4d8706

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md Outdated
Comment thread AGENTS.md Outdated
@qnbs

qnbs commented Aug 1, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #309. Review correctly established that the included native-notification feature requires a SemVer minor release. The branch was renamed to release/v1.26.0; GitHub automatically closed this PR during the rename. All review fixes are carried forward, including AUDIT.md alignment (00ddac4) and the complete 1.26.0 version synchronization (805a041).

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 805a0416e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
"name": "worldscript-studio",
"private": true,
"version": "1.25.0",
"version": "1.26.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Align the release tag with version 1.26.0

If this release is cut using the commit's still-current release gate, which explicitly instructs pushing v1.25.1, .github/workflows/tauri-build.yml:163-166 derives the updater version and download URLs from that tag while the binaries built from this field and the synchronized Tauri manifests identify themselves as 1.26.0. This would publish 1.26.0 artifacts under v1.25.1 and advertise them as updater version 1.25.1, making release metadata and subsequent update ordering inconsistent. Fresh evidence beyond the prior SemVer comment is that the raw commit metadata still names and instructs tagging 1.25.1 after the files were advanced to 1.26.0; update the commit/release instructions before tagging.

AGENTS.md reference: AGENTS.md:L339-L342

Useful? React with 👍 / 👎.

Comment thread CHANGELOG.md
Comment on lines +37 to +38
no longer trigger false `BACKPRESSURE`; priority order and FIFO-within-tier are preserved under
saturation, and completed progress iterators terminate instead of hanging. (#307)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Qualify the scheduler ordering guarantee

When same-priority tasks target different pools and the older task's pool has no available worker, WorkerBus.dequeueRunnableTask() calls PriorityTaskQueue.dequeueFirst(), whose findIndex(predicate) skips that older entry and dispatches a newer runnable entry; an unavailable critical task can similarly be bypassed by a runnable lower-priority task. Therefore the unqualified claim that priority order and FIFO-within-tier are preserved under saturation is false for the multi-pool scheduler; describe these guarantees as applying among runnable tasks rather than documenting strict global ordering.

AGENTS.md reference: AGENTS.md:L459-L464

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants