Conversation
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2001:style:15:3: See if you can use ${variable//search/replace} instead [shellcheck]
udfread/.github/workflows/build.yml
Line 32 in bb51e49
There was a problem hiding this comment.
🟢 Approval recommended
Patch references were removed consistently (no remaining workflow or repo references), and the workflow logic remains coherent while simplifying the build/release process.
Pull request overview
This PR removes an internal patching step from the release/build workflow, relying on upstream libudfread as-is and eliminating the maintenance overhead of carrying local compatibility patches.
Changes:
- Deleted the
libudfreadcompatibility patch file frompatches/. - Updated the GitHub Actions build workflow to stop applying/committing the patch and to remove patch-related release notes text.
File summaries
| File | Description |
|---|---|
| patches/libudfread-vds-fixes.patch | Removes the previously maintained downstream patch. |
| .github/workflows/build.yml | Drops patch application/commit steps and removes patch-specific release note statements. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
No description provided.