Add test coverage for safety/emoji.py - #911
Open
userjuma wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
safety/emoji.pyhad no test coverage at all — three pure functions (process_custom_emojis,process_rich_emojis_fallback,load_emoji) handling the custom:icon_*:namespace and ASCII fallbacks for environments that can't render emoji, with zero tests exercising any of it. Added a full test suite for the module.Type of Change
Related Issues
Related to #573
Testing
Added
tests/test_emoji.pywith 14 tests covering: known icon/emoji codes replaced correctly (both unicode and ASCII fallback paths), unknown codes left untouched rather than stripped or mis-replaced, non-string input handled gracefully, multiple codes in one string, and theload_emoji()branching behavior specifically — Rich emoji codes are only touched whenuse_ascii=True, verified that stays true rather than assumed.Ran the full suite (
pytest -q): 885 passed, 14 skipped, 1 pre-existing unrelated flake intests/auth/test_status.py(a timing assertion,duration_ms > 0, unrelated to this change).Checklist
Additional Notes
Picked this up via the general test-coverage issue (#573), which asks contributors to find an untested area and link back —
emoji.pyhad no matching test file intests/.