Skip to content

Fit the reference model's ring buffer to its 32-token prefill in the Muse Glimmer export test - #25038

Open
shoumikhin wants to merge 1 commit into
mainfrom
shoumikhin/fix-muse-glimmer-export-test-ring
Open

shoumikhin wants to merge 1 commit into
mainfrom
shoumikhin/fix-muse-glimmer-export-test-ring

Conversation

@shoumikhin

Copy link
Copy Markdown
Contributor

#24979 sized the sliding-window ring buffer from the largest prefill chunk, which defaults to the window size. In test_cuda_sequence_export_inputs the window is 16, so the ring now has 31 slots. But the reference model takes all 32 tokens in one write. The write wraps around the ring, so the reference logits come out wrong and the test fails with a max difference of about 0.33 (the limit is 0.05). This turned unittest / linux, unittest-editable / linux and unittest-release / linux red on main.

This sets the reference model's max prefill chunk to 32, so its ring holds the whole write. The exported program is unchanged.

Tested: ran the same model setup on CPU. The one-shot 32-token reference now matches the same tokens fed as two 16-token chunks exactly. Without the change it differs by 0.3335, the same number CI reports.

…Muse Glimmer export test

#24979 sized the sliding-window ring buffer from the largest prefill chunk,
which defaults to the window size. In test_cuda_sequence_export_inputs the
window is 16, so the ring now has 31 slots, but the reference model takes all
32 tokens in one write. The write wraps around the ring and the reference
logits come out wrong, so the test fails with a max difference of about 0.33
against the exported program (limit 0.05). This turned unittest / linux,
unittest-editable / linux and unittest-release / linux red on main.

Set the reference model's max prefill chunk to 32 so its ring holds the whole
write. The exported program is unchanged.

Checked by running the same model setup on CPU: the one-shot 32-token reference
now matches the same tokens fed as two 16-token chunks exactly, and without the
change it differs by 0.33.
@shoumikhin shoumikhin added release notes: none Do not include this in the release notes topic: not user facing labels Nov 13, 2026
@shoumikhin
shoumikhin requested review from Gasoonjia and a balanced review from Copilot November 13, 2026 17:01
@pytorch-bot

pytorch-bot Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/25038

Note: Links to docs will display an error until the docs builds have been completed.

❌ You can merge normally! (2 Unrelated Failures), 1 Unclassified Failure

As of commit b640c0d with merge base 311d96d (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

This branch was previously deployed

1 inactive deployment
cadence — b640c0d9 Deployed Nov 13, 2026 by shoumikhin via hifi5s-op-test / hifi5s #38233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants