Repository navigation
Drop the ESP-IDF dev version's date check and restructure the Espressif README - #24994
Conversation
…if README A dev version of the ESP-IDF component could only publish the previous day's nightly, between 00:00 UTC and the next nightly cut, because a second nightly the same day would replace that day's wheels. This repository does not re-cut nightlies, and a component paired with wheels from another commit fails closed, since gen_kernels.py refuses to make its kernel bundles. The check cost about 11 hours on every urgent fix, so this drops it. The wheel check still requires every wheel of the nightly, built from the nightly's commit. The Espressif README opened with the generated component, in a long block of CI detail, before the runner it documents. It now leads with the targets, the directory's layout and the quick start, and ends with the component: how to use it from the registry, how to generate it, and how to publish each kind of version. The one-time setup and the v* tag ruleset it asked for are gone; the environment's reviewers check each run's commit instead. Test plan: the wheel check accepts today's nightly, 1.6.0-dev.20261112, whose 20 wheels were all built from 2a00808, where the old script refused it, and rehearse passes. Authored with Claude Code.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24994
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Pending, 4 Unrelated Failures, 1 Unclassified FailureAs of commit 2b69821 with merge base fe738a3 ( UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@claude review |
The runner, the ESP-NN backend's manifests and camera_stream asked for ESP-IDF 5.1 or newer, a floor carried over from the first runner example that nothing tests: CI builds the runner on ESP-IDF 6.1 and the ESP-IDF component, which already requires 6.0, on 6.0.1, 6.1 and master. This raises them to 6.0, so the README can state one requirement, with setup.sh installing 6.1 within it. Authored with Claude Code.
A dev version of the ESP-IDF component could only publish the previous day's
nightly, between 00:00 UTC and the next nightly cut, because a second nightly
the same day would replace that day's wheels. This repository does not re-cut
nightlies, and a component paired with wheels from another commit fails
closed, since gen_kernels.py refuses to make its kernel bundles. The check cost
about 11 hours on every urgent fix, so this drops it. The wheel check still
requires every wheel of the nightly, built from the nightly's commit.
The Espressif README opened with the generated component, in a long block of
CI detail, before the runner it documents. It now leads with the targets, the
directory's layout and the quick start, and ends with the component: how to
use it from the registry, how to generate it, and how to publish each kind of
version. The one-time setup and the v* tag ruleset it asked for are gone; the
environment's reviewers check each run's commit instead.
The runner, the ESP-NN backend's manifests and camera_stream asked for ESP-IDF
5.1 or newer, a floor carried over from the first runner example that nothing
tests: CI builds the runner on ESP-IDF 6.1 and the ESP-IDF component, which
already requires 6.0, on 6.0.1, 6.1 and master. This raises them to 6.0, so the
README can state one requirement, with setup.sh installing 6.1 within it.
Test plan: the wheel check accepts today's nightly, 1.6.0-dev.20261112, whose
20 wheels were all built from 2a00808, where the old script refused it, and
rehearse passes.
Authored with Claude Code.