Skip to content

Drop the ESP-IDF dev version's date check and restructure the Espressif README - #24994

Merged
rascani merged 2 commits into
mainfrom
esp-readme-rewrite
Nov 13, 2026
Merged

rascani merged 2 commits into
mainfrom
esp-readme-rewrite

Conversation

@rascani

@rascani rascani commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

A dev version of the ESP-IDF component could only publish the previous day's
nightly, between 00:00 UTC and the next nightly cut, because a second nightly
the same day would replace that day's wheels. This repository does not re-cut
nightlies, and a component paired with wheels from another commit fails
closed, since gen_kernels.py refuses to make its kernel bundles. The check cost
about 11 hours on every urgent fix, so this drops it. The wheel check still
requires every wheel of the nightly, built from the nightly's commit.

The Espressif README opened with the generated component, in a long block of
CI detail, before the runner it documents. It now leads with the targets, the
directory's layout and the quick start, and ends with the component: how to
use it from the registry, how to generate it, and how to publish each kind of
version. The one-time setup and the v* tag ruleset it asked for are gone; the
environment's reviewers check each run's commit instead.

The runner, the ESP-NN backend's manifests and camera_stream asked for ESP-IDF
5.1 or newer, a floor carried over from the first runner example that nothing
tests: CI builds the runner on ESP-IDF 6.1 and the ESP-IDF component, which
already requires 6.0, on 6.0.1, 6.1 and master. This raises them to 6.0, so the
README can state one requirement, with setup.sh installing 6.1 within it.

Test plan: the wheel check accepts today's nightly, 1.6.0-dev.20261112, whose
20 wheels were all built from 2a00808, where the old script refused it, and
rehearse passes.

Authored with Claude Code.

…if README

A dev version of the ESP-IDF component could only publish the previous day's
nightly, between 00:00 UTC and the next nightly cut, because a second nightly
the same day would replace that day's wheels. This repository does not re-cut
nightlies, and a component paired with wheels from another commit fails
closed, since gen_kernels.py refuses to make its kernel bundles. The check cost
about 11 hours on every urgent fix, so this drops it. The wheel check still
requires every wheel of the nightly, built from the nightly's commit.

The Espressif README opened with the generated component, in a long block of
CI detail, before the runner it documents. It now leads with the targets, the
directory's layout and the quick start, and ends with the component: how to
use it from the registry, how to generate it, and how to publish each kind of
version. The one-time setup and the v* tag ruleset it asked for are gone; the
environment's reviewers check each run's commit instead.

Test plan: the wheel check accepts today's nightly, 1.6.0-dev.20261112, whose
20 wheels were all built from 2a00808, where the old script refused it, and
rehearse passes.

Authored with Claude Code.
@pytorch-bot

pytorch-bot Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24994

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Pending, 4 Unrelated Failures, 1 Unclassified Failure

As of commit 2b69821 with merge base fe738a3 (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rascani

rascani commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@claude review

Comment thread examples/espressif/README.md Resolved
Comment thread examples/espressif/README.md Resolved
The runner, the ESP-NN backend's manifests and camera_stream asked for ESP-IDF
5.1 or newer, a floor carried over from the first runner example that nothing
tests: CI builds the runner on ESP-IDF 6.1 and the ESP-IDF component, which
already requires 6.0, on 6.0.1, 6.1 and master. This raises them to 6.0, so the
README can state one requirement, with setup.sh installing 6.1 within it.

Authored with Claude Code.
@rascani
rascani merged commit fa84acd into main Nov 13, 2026
418 of 423 checks passed
@rascani
rascani deleted the esp-readme-rewrite branch November 13, 2026 20:42

This branch was previously deployed

1 inactive deployment
cadence — 2b698215 Deployed Nov 13, 2026 by rascani via hifi-op-test / hifi4 #38258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants