[ET-VK][ez] Fix conv2d_gemm_dynamic_test build against updated XNNPACK API#20911
Merged
Conversation
…K API XNNPACK updated two f32 conv2d entry points and `conv2d_gemm_dynamic_test.cpp` still called the old signatures, breaking the build (and thus the `etvk-eureka-tests` CI workflow). `xnn_create_convolution2d_nhwc_f32` gained an `xnn_code_cache_t code_cache` parameter before `weights_cache` (22 -> 23 args), and `xnn_reshape_convolution2d_nhwc_f32` gained a `size_t* workspace_alignment` out-param after `workspace_size` (8 -> 9 args). Updated both call sites: pass `nullptr` for `code_cache`, and pass `&workspace_alignment` (now written back by XNNPACK). Differential Revision: [D111934764](https://our.internmc.facebook.com/intern/diff/D111934764/) ghstack-source-id: 402834443 Pull-Request: #20910
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20911
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 144 PendingAs of commit d949496 with merge base b1dd46a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
This PR needs a
|
SS-JIA
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #20910 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/571/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/571/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/571/orig
Differential Revision: D111934764
@diff-train-skip-merge