Skip to content

Fix MODEL_CONVERTER_LIB_DIR path resolution for VGF tests (#20907)#20907

Open
psiddh wants to merge 1 commit into
pytorch:mainfrom
psiddh:export-D111819484
Open

Fix MODEL_CONVERTER_LIB_DIR path resolution for VGF tests (#20907)#20907
psiddh wants to merge 1 commit into
pytorch:mainfrom
psiddh:export-D111819484

Conversation

@psiddh

@psiddh psiddh commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary:

After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests
(mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed()
returns False on sandcastle.

Root cause: MODEL_CONVERTER_LIB_DIR was set to
$(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64
which relies on string concatenation after $(location) expansion. In Buck2 test
sandboxes, this pattern can produce an invalid path because the export_file
artifact reference may not expose subdirectories properly.

Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory
and reference it directly with $(location), eliminating the string concatenation.

Impact: −160 SKIPPING tests

Reviewed By: rascani

Differential Revision: D111819484

Copilot AI review requested due to automatic review settings July 14, 2026 14:51
@psiddh psiddh requested a review from digantdesai as a code owner July 14, 2026 14:51
@pytorch-bot

pytorch-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20907

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Cancelled Jobs, 1 Unrelated Failure, 7 Unclassified Failures

As of commit f496e8a with merge base 430ae39 (image):

NEW FAILURE - The following job has failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

  • Build Presets (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
  • Check Labels / Check labels (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    # This PR needs a release notes: label
  • Test ARM Backend (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
  • Test QNN Backend (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
  • Test Vulkan Backend (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
  • Test WebGPU Backend (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
  • Test XNNPACK Backend (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 14, 2026
@meta-codesync

meta-codesync Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D111819484.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Buck2 test environment for Arm VGF tests to make MODEL_CONVERTER_LIB_DIR resolve reliably in sandboxed test execution, avoiding path construction via string concatenation after $(location) expansion.

Changes:

  • Replace $(location ...:linux-x86_64)/host-linux-x64 with a direct $(location ...:host-linux-x64-libs) reference for MODEL_CONVERTER_LIB_DIR.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@meta-codesync meta-codesync Bot changed the title Fix MODEL_CONVERTER_LIB_DIR path resolution for VGF tests Fix MODEL_CONVERTER_LIB_DIR path resolution for VGF tests (#20907) Jul 14, 2026
psiddh added a commit to psiddh/executorch that referenced this pull request Jul 14, 2026
)

Summary:

After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests
(mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed()
returns False on sandcastle.

Root cause: MODEL_CONVERTER_LIB_DIR was set to
  $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64
which relies on string concatenation after $(location) expansion. In Buck2 test
sandboxes, this pattern can produce an invalid path because the export_file
artifact reference may not expose subdirectories properly.

Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory
and reference it directly with $(location), eliminating the string concatenation.

Impact: −160 SKIPPING tests

Reviewed By: rascani

Differential Revision: D111819484
@psiddh psiddh force-pushed the export-D111819484 branch from d0caa12 to b075bb8 Compare July 14, 2026 15:04
Copilot AI review requested due to automatic review settings July 15, 2026 05:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

psiddh added a commit to psiddh/executorch that referenced this pull request Jul 15, 2026
)

Summary:

After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests
(mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed()
returns False on sandcastle.

Root cause: MODEL_CONVERTER_LIB_DIR was set to
  $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64
which relies on string concatenation after $(location) expansion. In Buck2 test
sandboxes, this pattern can produce an invalid path because the export_file
artifact reference may not expose subdirectories properly.

Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory
and reference it directly with $(location), eliminating the string concatenation.

Impact: −160 SKIPPING tests

Reviewed By: rascani

Differential Revision: D111819484
@psiddh psiddh force-pushed the export-D111819484 branch from 6bdaa71 to 728c92b Compare July 15, 2026 05:43
psiddh added a commit to psiddh/executorch that referenced this pull request Jul 15, 2026
)

Summary:

After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests
(mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed()
returns False on sandcastle.

Root cause: MODEL_CONVERTER_LIB_DIR was set to
  $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64
which relies on string concatenation after $(location) expansion. In Buck2 test
sandboxes, this pattern can produce an invalid path because the export_file
artifact reference may not expose subdirectories properly.

Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory
and reference it directly with $(location), eliminating the string concatenation.

Impact: −160 SKIPPING tests

Reviewed By: rascani

Differential Revision: D111819484
@psiddh psiddh force-pushed the export-D111819484 branch from 728c92b to f496e8a Compare July 15, 2026 05:51
psiddh added a commit to psiddh/executorch that referenced this pull request Jul 15, 2026
)

Summary:
Pull Request resolved: pytorch#20907

After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests
(mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed()
returns False on sandcastle.

Root cause: MODEL_CONVERTER_LIB_DIR was set to
  $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64
which relies on string concatenation after $(location) expansion. In Buck2 test
sandboxes, this pattern can produce an invalid path because the export_file
artifact reference may not expose subdirectories properly.

Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory
and reference it directly with $(location), eliminating the string concatenation.

Impact: −160 SKIPPING tests

Reviewed By: rascani

Differential Revision: D111819484
@psiddh psiddh force-pushed the export-D111819484 branch from f496e8a to 82949df Compare July 15, 2026 05:52
)

Summary:

After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests
(mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed()
returns False on sandcastle.

Root cause: MODEL_CONVERTER_LIB_DIR was set to
  $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64
which relies on string concatenation after $(location) expansion. In Buck2 test
sandboxes, this pattern can produce an invalid path because the export_file
artifact reference may not expose subdirectories properly.

Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory
and reference it directly with $(location), eliminating the string concatenation.

Impact: −160 SKIPPING tests

Reviewed By: rascani

Differential Revision: D111819484
@psiddh psiddh force-pushed the export-D111819484 branch from 82949df to a84ed6f Compare July 15, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants