Fix MODEL_CONVERTER_LIB_DIR path resolution for VGF tests (#20907)#20907
Fix MODEL_CONVERTER_LIB_DIR path resolution for VGF tests (#20907)#20907psiddh wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20907
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Cancelled Jobs, 1 Unrelated Failure, 7 Unclassified FailuresAs of commit f496e8a with merge base 430ae39 ( NEW FAILURE - The following job has failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D111819484. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Buck2 test environment for Arm VGF tests to make MODEL_CONVERTER_LIB_DIR resolve reliably in sandboxed test execution, avoiding path construction via string concatenation after $(location) expansion.
Changes:
- Replace
$(location ...:linux-x86_64)/host-linux-x64with a direct$(location ...:host-linux-x64-libs)reference forMODEL_CONVERTER_LIB_DIR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
) Summary: After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
d0caa12 to
b075bb8
Compare
) Summary: After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
6bdaa71 to
728c92b
Compare
) Summary: After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
728c92b to
f496e8a
Compare
) Summary: Pull Request resolved: pytorch#20907 After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
f496e8a to
82949df
Compare
) Summary: After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
82949df to
a84ed6f
Compare
Summary:
After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests
(mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed()
returns False on sandcastle.
Root cause: MODEL_CONVERTER_LIB_DIR was set to
$(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64
which relies on string concatenation after $(location) expansion. In Buck2 test
sandboxes, this pattern can produce an invalid path because the export_file
artifact reference may not expose subdirectories properly.
Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory
and reference it directly with $(location), eliminating the string concatenation.
Impact: −160 SKIPPING tests
Reviewed By: rascani
Differential Revision: D111819484