Skip to content

[ET][Windows] Fix ExecuTorch Windows host build portability defects #20898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SS-JIA wants to merge 3 commits into from
Closed

[ET][Windows] Fix ExecuTorch Windows host build portability defects #20898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7365aaa
Update
SS-JIA Jul 13, 2026
6b805ce
Update
SS-JIA Jul 14, 2026
c8ff70f
Update
SS-JIA Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backends/vulkan/runtime/api/containers/Tensor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,11 +549,11 @@ class vTensor final {
return sizes_;
}

inline const int64_t size(size_t dim) const {
inline int64_t size(size_t dim) const {
return sizes().at(dim);
}

inline const int64_t dim() const {
inline int64_t dim() const {
return sizes_.size();
}

Expand Down
4 changes: 4 additions & 0 deletions extension/data_loader/mman.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,13 @@ ET_INLINE void fcntl_rdadvise_apple(int fd, size_t file_size) {

#else

#ifndef NOMINMAX
#define NOMINMAX
#include <windows.h>
#undef NOMINMAX
#else
#include <windows.h>
#endif
#include <io.h>

#include <executorch/extension/data_loader/mman_windows.h>
Expand Down
4 changes: 4 additions & 0 deletions extension/data_loader/mman_windows.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,13 @@
#include <io.h>
#include <cstdint>
#include <limits>
#ifndef NOMINMAX
#define NOMINMAX
#include <windows.h>
#undef NOMINMAX
#else
#include <windows.h>
#endif

#ifndef STATUS_SECTION_TOO_BIG
#define STATUS_SECTION_TOO_BIG 0xC0000040L
Expand Down
5 changes: 3 additions & 2 deletions runtime/core/portable_type/c10/c10/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,10 @@ def define_common_targets():
"ovr_config//build_mode:arvr_mode[enabled]": select({
"DEFAULT": ["fbsource//xplat/caffe2:ovrsource_aten_Config.h"],
# ovrsource_aten_Config.h is an oxx_static_library that only
# works on OVR-native platforms. On Android, it produces no
# outputs, so use the xplat variant instead.
# works on OVR-native platforms. On Android and the Windows
# host, it produces no outputs, so use the xplat variant.
"ovr_config//os:android": ["fbsource//xplat/caffe2:generated_aten_config_header"],
"ovr_config//os:windows": ["fbsource//xplat/caffe2:generated_aten_config_header"],
}),
}) + get_sleef_deps(),
fbcode_exported_deps = ([
Expand Down
Loading