Skip to content

Fix docs gh-pages publish authentication#20890

Merged
JacobSzwejbka merged 1 commit into
mainfrom
js/fix-doc-gh-pages-push-auth
Jul 13, 2026
Merged

Fix docs gh-pages publish authentication#20890
JacobSzwejbka merged 1 commit into
mainfrom
js/fix-doc-gh-pages-push-auth

Conversation

@JacobSzwejbka

Copy link
Copy Markdown
Contributor

Summary:

  • Stop passing DOC_BUILD_GITHUB_TOKEN into the docs gh-pages publish job.
  • Stop overriding origin with that token before pushing generated docs.
  • Let the checkout credentials use the job's existing contents: write permission for the gh-pages push.

Failure fixed:

Testing:

  • git diff --check

Notes:

  • PyYAML/actionlint are not installed in this local environment, so I could not run a workflow syntax parser locally.

@pytorch-bot

pytorch-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20890

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JacobSzwejbka

Copy link
Copy Markdown
Contributor Author

This also fixes https://github.com/pytorch/executorch/actions/runs/29265325297/job/86873583069. That job is still running the old docs publish script with secrets-env: DOC_BUILD_GITHUB_TOKEN and git remote set-url origin ...$SECRET_DOC_BUILD_GITHUB_TOKEN...; the push fails with Permission to pytorch/executorch.git denied to GregoryComer.

@JacobSzwejbka JacobSzwejbka merged commit d8e8d1e into main Jul 13, 2026
173 of 176 checks passed
@JacobSzwejbka JacobSzwejbka deleted the js/fix-doc-gh-pages-push-auth branch July 13, 2026 18:41
JacobSzwejbka added a commit that referenced this pull request Jul 13, 2026
Summary:
- Run the docs gh-pages publish script on the host instead of inside
Docker.
- Keep using actions/checkout persisted credentials for the
GITHUB_TOKEN-backed push.

Failure fixed:
- Post-#20890 docs publish jobs still fail at git push -f with fatal:
could not read Username for https://github.com: terminal prompts
disabled because the Dockerized script cannot see checkout credentials
from the host.

Testing:
- git diff --check
- Ruby YAML parse of .github/workflows/doc-build.yml

Notes:
- actionlint is not installed in this local environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants