Skip to content

Conversation

@seyeong-han
Copy link
Contributor

Questions

Does Windows 11 + Clang work? - setup.py

$ clang --version
clang version 19.1.5
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\Llvm\x64\bin
$ nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2025 NVIDIA Corporation
Built on Wed_Apr__9_19:29:17_Pacific_Daylight_Time_2025
Cuda compilation tools, release 12.9, V12.9.41
Build cuda_12.9.r12.9/compiler.35813241_0

Fix: windows + CUDA enforces to install cpu version of Torch

    if platform.system().lower() == "windows":
        # Try CUDA detection on Windows as well
        print("Windows detected, attempting CUDA detection...")
        try:
            cuda_version = _get_cuda_version(supported_cuda_versions)
            major, minor = cuda_version
            print(f"Detected CUDA version: {major}.{minor}")
            torch_url = _get_pytorch_cuda_url(cuda_version, torch_nightly_url_base)
            print(f"Using PyTorch URL: {torch_url}")
            return torch_url
        except Exception as err:
            print(f"CUDA detection failed ({err}), using CPU-only PyTorch")
            return f"{torch_nightly_url_base}/cpu"

Test Plan:

  • Run .\install_executorch.bat on Windows with CUDA 12.9 installed
  • Verify CMake configuration proceeds past CUDA compiler identification
  • Verify non-CUDA builds still use ClangCL toolset

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16321

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5573967 with merge base cea6be1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@seyeong-han seyeong-han marked this pull request as draft December 18, 2025 18:06
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 18, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant