Skip to content

Arm backend: Add support for Zephyr as a external module #16294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zingo merged 2 commits into from
Dec 19, 2025
Merged

Arm backend: Add support for Zephyr as a external module #16294

zingo merged 2 commits into from
Dec 19, 2025
+1,218 −5

Conversation

@zingo
Copy link
Collaborator

@zingo zingo commented Dec 17, 2025 •
edited
Loading

Summary

This commit has everything needed to build executorch from zephyr and include it as a external module without having any changes in zephyr.

Based on code by BujSet.

Test plan

Tested by hand. Plan to update GitHub testing for this in later PR

cc @freddan80 @per @oscarandersson8218 @digantdesai

Co-authored-by: BujSet <[email protected]>
Co-authored-by: Adrian Lundell <[email protected]>
Co-authored-by: Zingo Andersen <[email protected]>
Co-authored-by: Per Held <[email protected]>

@AdrianLundell @zingo
Arm backend: Add support for Zephyr as a external module
31f8796 
This commit has everything needed to build executorch from zephyr and
include it as a external module without having any changes in zephyr.

Based on code by BujSet.

Co-authored-by: BujSet <[email protected]>
Co-authored-by: Zingo Andersen <[email protected]>
Co-authored-by: Per Held <[email protected]>

Change-Id: I1a1aeb8aa02f1b5e3a578dd25d031919c9925019
Signed-off-by: Zingo Andersen <[email protected]>
@zingo zingo added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Dec 17, 2025
@zingo zingo requested a review from larryliu0820 as a code owner December 17, 2025 13:29
@zingo zingo added the release notes: arm Changes to the ARM backend delegate label Dec 17, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16294

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job, 1 Unrelated Failure

As of commit 6991033 with merge base cf8496a (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 17, 2025
zingo
zingo commented Dec 17, 2025
View reviewed changes
examples/arm/zephyr/prj.conf
CONFIG_CPP=y
CONFIG_STD_CPP17=y

# Needed as kernels/portable/cpu/op_allclose.cpp uses isfinite() instead of std::isfinite()
Copy link
Collaborator Author

@zingo zingo Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a PR on it's way to fix this, it will be uploaded after this is merged as it depends on this PR

zingo
zingo commented Dec 17, 2025
View reviewed changes
backends/arm/runtime/EthosUBackend.cpp
* ethos-u-core-driver for hardware interaction.
*/

// Workaround for runtime/core/portable_type/c10/c10/util/Float16-math.h
Copy link
Collaborator Author

@zingo zingo Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perheld have a PR on this here: #16221

@zingo zingo mentioned this pull request Dec 17, 2025
Open
@zingo
Copy link
Collaborator Author

zingo commented Dec 17, 2025

Hi @digantdesai this touches file outside Arm folders and need a non Arm review.

@zingo
Copy link
Collaborator Author

zingo commented Dec 18, 2025

For reference: There are some extra information about this PR in this discussions zephyrproject-rtos/zephyr#92981

@zingo zingo mentioned this pull request Dec 18, 2025
Open
larryliu0820
larryliu0820 approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake files are looking good to me. Preemptively accepting unless others have blocking comments.

@larryliu0820
Copy link
Contributor

larryliu0820 commented Dec 18, 2025

@zingo are we able to have a CI to cover the runner? Would be good to have an e2e CI, right now we only have a build preset CI.

rascani
rascani approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@rascani rascani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one tiny nit and +1 on @larryliu0820's comment about CI.

@zingo
Copy link
Collaborator Author

zingo commented Dec 19, 2025

@zingo are we able to have a CI to cover the runner? Would be good to have an e2e CI, right now we only have a build preset CI.

I think so, working on rewriting the old/current one (that is disabled) from Bujset to match this PR.

@zingo
Fix ZephyrOS review comments
6991033 
Signed-off-by: Zingo Andersen <[email protected]>
Change-Id: Ia5eec18ba42d8056332fb5f3e3699c6e85c81956
@zingo
Copy link
Collaborator Author

zingo commented Dec 19, 2025 •
edited
Loading

Hi @MartinPavella (or who might be a NXP person to notify :) ) when this is merged it might be easy for you to update/adopt and get some NXP targets already available in ZephyrOS working :)

@zingo zingo added this to the 1.1.0 milestone Dec 19, 2025
@zingo
Copy link
Collaborator Author

zingo commented Dec 19, 2025

Fails are unrelated

@zingo zingo merged commit cf28248 into pytorch:main Dec 19, 2025
290 of 294 checks passed
@github-project-automation github-project-automation bot moved this from To triage to Done in ExecuTorch Arm Backend Dec 19, 2025
@zingo zingo deleted the Arm-backend-Add-support-for-Zephyr-as-a-external-module branch December 19, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rascani rascani rascani approved these changes

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

@psiddh psiddh Awaiting requested review from psiddh

@mergennachin mergennachin Awaiting requested review from mergennachin

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

ExecuTorch Arm Backend
Status: Done

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@zingo @larryliu0820 @rascani @AdrianLundell