-
Notifications
You must be signed in to change notification settings - Fork 388
[mxfp8 moe training] update readme with kernel microbenchmarks for dsv3 #3521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielvegamyhre
wants to merge
1
commit into
danielvegamyhre/stack/89
Choose a base branch
from
danielvegamyhre/stack/90
base: danielvegamyhre/stack/89
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3521
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit 98e81e0 with merge base 7035fb7 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
danielvegamyhre
added a commit
that referenced
this pull request
Dec 20, 2025
stack-info: PR: #3521, branch: danielvegamyhre/stack/90
9953446 to
2070bb7
Compare
This was referenced Dec 20, 2025
danielvegamyhre
added a commit
that referenced
this pull request
Dec 20, 2025
stack-info: PR: #3521, branch: danielvegamyhre/stack/90
2070bb7 to
ac2f0a5
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Dec 20, 2025
stack-info: PR: #3521, branch: danielvegamyhre/stack/90
ac2f0a5 to
16e9bdc
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Dec 21, 2025
stack-info: PR: #3521, branch: danielvegamyhre/stack/90
16e9bdc to
6f6d495
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Dec 21, 2025
stack-info: PR: #3521, branch: danielvegamyhre/stack/90
6f6d495 to
23f82b3
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Dec 21, 2025
stack-info: PR: #3521, branch: danielvegamyhre/stack/90
23f82b3 to
c92cb6c
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Dec 21, 2025
stack-info: PR: #3521, branch: danielvegamyhre/stack/90
c92cb6c to
321d1f7
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Dec 22, 2025
stack-info: PR: #3521, branch: danielvegamyhre/stack/90
321d1f7 to
322ff0e
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Dec 22, 2025
stack-info: PR: #3521, branch: danielvegamyhre/stack/90
322ff0e to
2b20010
Compare
stack-info: PR: #3521, branch: danielvegamyhre/stack/90
2b20010 to
98e81e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
moe
mx
topic: documentation
Use this tag if this PR adds or improves documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[mxfp8 moe training] update readme with kernel microbenchmarks for dsv3
Add mxfp8 kernel microbenchmarks for DeepSeekV3 shapes, grouped by forward/dgrad/wgrad. With environment details and commands to reproduce.
As you can see, the last weak point that meaningfully affects performance for DSV3 is the per grouped blocked layout kernel for groups along M (used in forward). We should be able to easily make a modified version of the new CUDA kernel added in the stack that operates on groups along K to instead operate for groups along M and resolve this issue.
Preview: