gh-142787: Fix assertion failure in sqlite3 blob slice #142824
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdoulrasheed
requested review from
berkerpeksag and
erlend-aasland
as code owners
Contributor
|
Thanks for working on this! Please make sure this regression is covered by the test suite. |
erlend-aasland
added
needs backport to 3.13
Contributor
|
Hi, there is a duplicated news entry, please remove it. |
Abdoulrasheed
force-pushed
the
fix-issue-142787
branch
from
8c9bd46 to
577803c
Compare
Contributor
|
Moreover, please avoid force-pushing (as recommended by the devguide). |
Contributor
Author
Noted @erlend-aasland |
Lib/test/test_sqlite3/test_dbapi.py
Outdated
| self.assertEqual(self.blob[5:5], b"") | ||
|
|
||
| def test_blob_get_empty_slice_oob_indices(self): | ||
| self.cx.execute("delete from test") |
Contributor
There was a problem hiding this comment.
I prefer to leave this out. Just add a new row and blobopen it instead. Alternatively, make the test work with the pre-filled data in the constructor.
Contributor
Author
There was a problem hiding this comment.
@erlend-aasland The test has been updated.
aisk
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix assertion failure when slicing a
sqlite3.Blobwith indices that result in an empty slice.PyObject *read_multiple(pysqlite_Blob *, Py_ssize_t, Py_ssize_t): Assertion 'offset < sqlite3_blob_bytes(self->blob)' failed#142787