use constraints file for sdist/wheel build + get version using build.util #3167
use constraints file for sdist/wheel build + get version using build.util #3167
Conversation
fcbfe33 to
b63587a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3167 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 124 124
Lines 18427 18427
Branches 1215 1215
===============================================
Hits 18427 18427 |
|
If you're going this route already, let's also set |
| persist-credentials: false | ||
|
|
||
| - name: Install build | ||
| run: python -Im pip install build -c test-requirements.txt |
There was a problem hiding this comment.
This would leak into the underlying PEP 517 ephemeral build envs.
| run: python -Im pip install build -c test-requirements.txt | |
| env: | |
| PIP_CONSTRAINT: test-requirements.txt | |
| run: python -Im pip install build |
| run: python -Im pip install build | ||
|
|
||
| - name: Build dists | ||
| run: python -Im build |
There was a problem hiding this comment.
Assuming, you'll do something like pip-compile --only-build-deps --output-file=build-requirements.txt pyproject.toml:
| run: python -Im build | |
| env: | |
| PIP_CONSTRAINT: build-requirements.txt | |
| run: python -Im build |
| python -m uv --version | ||
|
|
||
| python -m uv pip install build | ||
| python -m uv pip install build -c test-requirements.txt |
There was a problem hiding this comment.
This could also use an env var:
| python -m uv pip install build -c test-requirements.txt | |
| PIP_CONSTRAINT=test-requirements.txt python -m uv pip install build |
webknjaz
left a comment
There was a problem hiding this comment.
Additionally, I realized that this project doesn't have a combined workflow and so this https://github.com/python-trio/trio/blob/main/.github/workflows/release.yml also needs to be handled similarly.
stuff that I wanted to sneak into the zizmor PR, but decided should be in another PR