Skip to content

fix: [#285] correct RAG optional-dependency install instructions (cofone -> fenn[rag-*]) - #286

Open
pcbeingused333 wants to merge 1 commit into
pyfenn:mainfrom
pcbeingused333:fix/rag-install-extras
Open

fix: [#285] correct RAG optional-dependency install instructions (cofone -> fenn[rag-*])#286
pcbeingused333 wants to merge 1 commit into
pyfenn:mainfrom
pcbeingused333:fix/rag-install-extras

Conversation

@pcbeingused333

Copy link
Copy Markdown

What

The RAG modules told users to pip install "cofone[pdf]" (and [web], [faiss]) in ImportError messages and docstrings. Corrected to the real distribution and extras: fenn[rag-pdf], fenn[rag-web], fenn[rag-faiss].

Why

cofone is not a valid distribution and the extras are named rag-* in pyproject.toml, so the previous commands fail with No matching distribution found.

Scope

10 strings across fenn/agents/rag/loader.py, retriever.py, rag.py. Left the [cofone] log prefixes untouched (separate concern — happy to follow up).

Testing

ruff check and ruff format --check pass; no tests referenced these strings.

Closes #285

@ApusBerliozi ApusBerliozi added bug Something isn't working templates Relates to templates labels Jul 28, 2026
@ApusBerliozi

ApusBerliozi commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Looks good for me, but I'm not so sure regarding dependencies...

@blkdmr, could you please also take a look at this one?

@pcbeingused333

Copy link
Copy Markdown
Author

Thanks for the review, @ApusBerliozi! 🙌 This might help: this PR only changes the text in the error messages and docstrings — it doesn't touch pyproject.toml or any actual dependency. The extras rag-pdf, rag-web, rag-faiss already exist in pyproject.toml; the messages were just pointing to names that don't resolve (cofone[pdf]). So after this change, pip install "fenn[rag-pdf]" (and [rag-web] / [rag-faiss]) match the real extras and actually work. Happy to adjust the wording if you'd prefer a different convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working templates Relates to templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RAG optional-dependency errors point to a non-existent "cofone[...]" package/extras

2 participants