fix: [#285] correct RAG optional-dependency install instructions (cofone -> fenn[rag-*]) - #286
Open
pcbeingused333 wants to merge 1 commit into
Open
fix: [#285] correct RAG optional-dependency install instructions (cofone -> fenn[rag-*])#286pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
…s (cofone -> fenn[rag-*])
Contributor
|
Looks good for me, but I'm not so sure regarding dependencies... @blkdmr, could you please also take a look at this one? |
ApusBerliozi
approved these changes
Jul 28, 2026
Author
|
Thanks for the review, @ApusBerliozi! 🙌 This might help: this PR only changes the text in the error messages and docstrings — it doesn't touch pyproject.toml or any actual dependency. The extras rag-pdf, rag-web, rag-faiss already exist in pyproject.toml; the messages were just pointing to names that don't resolve (cofone[pdf]). So after this change, pip install "fenn[rag-pdf]" (and [rag-web] / [rag-faiss]) match the real extras and actually work. Happy to adjust the wording if you'd prefer a different convention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The RAG modules told users to
pip install "cofone[pdf]"(and[web],[faiss]) in ImportError messages and docstrings. Corrected to the real distribution and extras:fenn[rag-pdf],fenn[rag-web],fenn[rag-faiss].Why
cofoneis not a valid distribution and the extras are namedrag-*inpyproject.toml, so the previous commands fail withNo matching distribution found.Scope
10 strings across
fenn/agents/rag/loader.py,retriever.py,rag.py. Left the[cofone]log prefixes untouched (separate concern — happy to follow up).Testing
ruff checkandruff format --checkpass; no tests referenced these strings.Closes #285