Add support for ImageGenerationTool output_compression and output_format for Vertex AI Gemini image models
#3759
+263
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_format` for Vertex AI Gemini image models
h0rv
force-pushed
the
robby/add-gemini-output-mime-type-support
branch
from
51b8ccd to
d04282d
Compare
h0rv
force-pushed
the
robby/add-gemini-output-mime-type-support
branch
from
9ac31a2 to
9df6bcd
Compare
DouweM
requested changes
Dec 18, 2025
| Supported by: | ||
| * OpenAI Responses. Default: 'png'. | ||
| * Google (Vertex AI only). |
Collaborator
There was a problem hiding this comment.
Can you add in the default, which I'm assuming is also PNG?
|
|
||
| # Test output_format rejection | ||
| agent = Agent(model, builtin_tools=[ImageGenerationTool(output_format='png')], output_type=BinaryImage) | ||
| with pytest.raises(ValueError, match='output_mime_type parameter is not supported in Gemini API'): |
Collaborator
There was a problem hiding this comment.
Instead of hitting errors, let's ignore the field silently as we would've done before. We've already documented it only works with Vertex, so we can check self.system == 'google-vertex' inside GoogleModel
| Supported by: | ||
| * OpenAI Responses. Only supported for 'png' and 'webp' output formats. | ||
| * Google (Vertex AI only). Only supported for 'jpeg' output format. |
Collaborator
There was a problem hiding this comment.
Please update the docs as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, these options are only available via vertex-ai, not google-gla