-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Support inject_schema_instructions_in_native_mode #3744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xcpky
wants to merge
4
commits into
pydantic:main
Choose a base branch
from
xcpky:native-output
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+147
−41
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| from pydantic import BaseModel | ||
|
|
||
| from pydantic_ai import Agent | ||
| from pydantic_ai.models.test import TestModel | ||
| from pydantic_ai.output import NativeOutput | ||
| from pydantic_ai.profiles import ModelProfile | ||
|
|
||
|
|
||
| class City(BaseModel): | ||
| name: str | ||
| population: int | ||
|
|
||
|
|
||
| async def test_native_output_schema_injection_from_profile(): | ||
| """ | ||
| Test that `native_output_requires_schema_in_instructions=True` in the profile | ||
| causes the schema instructions to be injected, even when using `NativeOutput` implicitly or explicitly. | ||
| """ | ||
| profile = ModelProfile( | ||
| supports_json_schema_output=True, | ||
| default_structured_output_mode='native', | ||
| native_output_requires_schema_in_instructions=True, | ||
| prompted_output_template='SCHEMA: {schema}', | ||
| ) | ||
| model = TestModel(profile=profile, custom_output_text='{ "name": "Paris", "population": 9000000 }') | ||
| agent = Agent(model, output_type=City) | ||
|
|
||
| await agent.run('Paris') | ||
|
|
||
| params = model.last_model_request_parameters | ||
| assert params | ||
| assert params.prompted_output_instructions is not None | ||
| assert 'SCHEMA:' in params.prompted_output_instructions | ||
| assert 'City' in params.prompted_output_instructions | ||
|
|
||
|
|
||
| async def test_native_output_custom_template_override(): | ||
| """ | ||
| Test that providing a `template` in `NativeOutput` uses that template, | ||
| regardless of the profile setting (even if injection is disabled in profile). | ||
| """ | ||
| profile = ModelProfile( | ||
| supports_json_schema_output=True, | ||
| default_structured_output_mode='native', | ||
| native_output_requires_schema_in_instructions=False, # Disabled in profile | ||
| ) | ||
| model = TestModel(profile=profile, custom_output_text='{ "name": "London", "population": 9000000 }') | ||
| agent = Agent(model) | ||
|
|
||
| # Use NativeOutput with explicit template | ||
| await agent.run( | ||
| 'London', | ||
| output_type=NativeOutput(City, template='CUSTOM TEMPLATE: {schema}'), | ||
| ) | ||
|
|
||
| params = model.last_model_request_parameters | ||
| assert params | ||
| assert params.prompted_output_instructions is not None | ||
| assert 'CUSTOM TEMPLATE:' in params.prompted_output_instructions | ||
| assert 'City' in params.prompted_output_instructions | ||
|
|
||
|
|
||
| async def test_native_output_custom_template_precedence(): | ||
| """ | ||
| Test that providing a `template` in `NativeOutput` takes precedence over the profile default, | ||
| even if injection is enabled in the profile. | ||
| """ | ||
| profile = ModelProfile( | ||
| supports_json_schema_output=True, | ||
| default_structured_output_mode='native', | ||
| native_output_requires_schema_in_instructions=True, | ||
| prompted_output_template='DEFAULT SCHEMA: {schema}', | ||
| ) | ||
| model = TestModel(profile=profile, custom_output_text='{ "name": "China", "population": 9000000 }') | ||
| agent = Agent(model) | ||
|
|
||
| await agent.run( | ||
| 'China', | ||
| output_type=NativeOutput(City, template='OVERRIDE TEMPLATE: {schema}'), | ||
| ) | ||
|
|
||
| params = model.last_model_request_parameters | ||
| assert params | ||
| assert params.prompted_output_instructions is not None | ||
| assert 'OVERRIDE TEMPLATE:' in params.prompted_output_instructions | ||
| assert 'DEFAULT SCHEMA:' not in params.prompted_output_instructions | ||
|
|
||
|
|
||
| async def test_native_output_no_injection_by_default(): | ||
| """ | ||
| Test that without the profile setting and without a custom template, | ||
| no instructions are injected for NativeOutput (default behavior). | ||
| """ | ||
| profile = ModelProfile( | ||
| supports_json_schema_output=True, | ||
| default_structured_output_mode='native', | ||
| native_output_requires_schema_in_instructions=False, | ||
| ) | ||
| model = TestModel(profile=profile, custom_output_text='{ "name": "Tokyo", "population": 9000000 }') | ||
| agent = Agent(model, output_type=City) | ||
|
|
||
| await agent.run('Tokyo') | ||
|
|
||
| params = model.last_model_request_parameters | ||
| assert params | ||
| assert params.prompted_output_instructions is None |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users mostly don't deal with profile fields directly, and should be able to assume that we've done our best to make them correct out of the box so that they don't have to worry about them, so I'd rather say: