Repository navigation
fix(formula): bin pandas Categorical columns in i() - #2037
Draft
mayuriphad wants to merge 2 commits into
Draft
mayuriphad wants to merge 2 commits into
mayuriphad wants to merge 2 commits into
Conversation
Signed-off-by: mayuriphad <mayuriphad656@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
fixest's bin_factor keeps a bin at the position of the first value listed in bin, not at the first binned level. With categories cherry, banana, apple and bin fruit = apple, cherry the levels are now banana, fruit, which matches R in test_binning_categorical. Signed-off-by: mayuriphad <mayuriphad656@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1910.
i(x, bin=...)now bins a pandasCategoricalcolumn the way it bins a string column._apply_binningusedSeries.replace, which cannot introduce a new category, so it raised under pandas 3 and warned under pandas 2. For aCategoricalit now rebuilds the categories, and each bin takes the place of the first value listed for it, as infixest'sbin_factor. String and numeric columns still go throughreplaceunchanged.Verification
Passed:
tests/test_others.py -k bin(4 passed) under both pandas 2.3.3 and pandas 3.1.1. That includes the newtest_i_bin_categoricalfor unordered and ordered categoricals, which fails onmasterunder pandas 3.ruff checkandruff format --checkare clean on the changed files.Not run locally:
tests/test_i.py::test_binning_categorical, the new comparison againstfixest(non-alphabetical categories, with and without a continuous interaction). It needs R andrpy2, which I don't have here, so CI is the evidence for it. I tested on Windows with the compiled_core_implfrom the 0.70.0 wheel over this checkout, without pixi.