Skip to content

ci: scan and check links in the verify job - #96

Merged
altaywtf merged 1 commit into
mainfrom
fix/verify-scan-links
Oct 5, 2026
Merged

altaywtf merged 1 commit into
mainfrom
fix/verify-scan-links

Conversation

@altaywtf

@altaywtf altaywtf commented Oct 5, 2026

Copy link
Copy Markdown
Member

Summary

Moves the secret and workflow scan and the Markdown link check into the verify job as the shared actions/scan and actions/links steps (v1.2.0), and deletes the Scan and Links caller workflows.

Event Jobs before Jobs after
Pull request Verify, Links, Gitleaks, TruffleHog (+ Actionlint, Zizmor when .github/ changes) Verify
main push Verify, Links, release Verify, release
Weekly schedule Gitleaks, TruffleHog, Actionlint, Zizmor none
Manual dispatch Scan's 4 jobs Verify with a full-history scan

Verification

  • actionlint and zizmor 1.30.1 report nothing; vp run verify passes.
  • The links command with lychee 0.24.2 passes on this branch and exits 2 with a seeded missing file and anchor.

Notes

  • On a main push the scan audits workflows with Actionlint and Zizmor only when the pushed range changes them. Gitleaks stays off for this public repository, which relies on GitHub secret scanning and push protection.
  • Concurrency moves to the workflow and cancels only superseded pull-request runs; main runs queue so each pushed range is scanned. Distribution says so.
  • Merging runs CI on main: verify and the semantic-release job, which publishes nothing for a ci: commit.

Written by an agent (Claude Code, Claude Opus 5.5)

Replace the Scan and Links caller workflows with the putdotio/.github v1.2.0 scan and links actions as the last steps of verify. CI gains workflow_dispatch for a full-history scan, and only pull-request runs cancel when superseded.
Copilot AI balanced review requested due to automatic review settings October 5, 2026 06:01
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@altaywtf
altaywtf merged commit 1c988c5 into main Oct 5, 2026
@altaywtf
altaywtf deleted the fix/verify-scan-links branch October 5, 2026 06:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

It restructures release-gating CI and concurrency behavior on main, a publishing-critical path that warrants final human review despite no defects found.

Review effort: Balanced
Findings: None

What changed in this PR

This PR consolidates CI checks for the taizn Tizen packaging harness. It folds the previously standalone Scan (Gitleaks/TruffleHog/Actionlint/Zizmor) and Links (offline Markdown link/anchor) caller workflows into two shared-action steps at the end of the existing verify job in ci.yml, deletes those two workflows, adds a workflow_dispatch trigger, and moves concurrency from the job to the workflow (cancelling only superseded pull-request runs while letting main runs queue). Documentation in DISTRIBUTION.md is updated to describe the new flow.

Changes:

  • Add links and scan shared actions (putdotio/.github@…v1.2.0) as steps in the verify job, with the scan step guarded by if: ${{ !cancelled() }}.
  • Delete .github/workflows/scan.yml and .github/workflows/links.yml; add workflow_dispatch and workflow-level concurrency (cancel-in-progress only for pull requests).
  • Update docs/DISTRIBUTION.md to describe the consolidated verify-job checks and the new concurrency/queueing behavior.
File Description
.github/​workflows/​ci.yml Adds workflow_dispatch, workflow-level concurrency, and links/scan steps in verify; removes job-level concurrency.
.github/​workflows/​scan.yml Deleted; scan behavior moved into the verify job.
.github/​workflows/​links.yml Deleted; link check moved into the verify job.
docs/​DISTRIBUTION.md Updates CI narrative to reflect consolidated checks and queue/cancel behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@putio-ci

putio-ci Bot commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@putio-ci putio-ci Bot added the released label Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants