Repository navigation
ci: scan and check links in the verify job - #96
Conversation
Replace the Scan and Links caller workflows with the putdotio/.github v1.2.0 scan and links actions as the last steps of verify. CI gains workflow_dispatch for a full-history scan, and only pull-request runs cancel when superseded.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
It restructures release-gating CI and concurrency behavior on main, a publishing-critical path that warrants final human review despite no defects found.
Review effort: Balanced
Findings: None
What changed in this PR
This PR consolidates CI checks for the taizn Tizen packaging harness. It folds the previously standalone Scan (Gitleaks/TruffleHog/Actionlint/Zizmor) and Links (offline Markdown link/anchor) caller workflows into two shared-action steps at the end of the existing verify job in ci.yml, deletes those two workflows, adds a workflow_dispatch trigger, and moves concurrency from the job to the workflow (cancelling only superseded pull-request runs while letting main runs queue). Documentation in DISTRIBUTION.md is updated to describe the new flow.
Changes:
- Add
linksandscanshared actions (putdotio/.github@…v1.2.0) as steps in theverifyjob, with the scan step guarded byif: ${{ !cancelled() }}. - Delete
.github/workflows/scan.ymland.github/workflows/links.yml; addworkflow_dispatchand workflow-level concurrency (cancel-in-progressonly for pull requests). - Update
docs/DISTRIBUTION.mdto describe the consolidated verify-job checks and the new concurrency/queueing behavior.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds workflow_dispatch, workflow-level concurrency, and links/scan steps in verify; removes job-level concurrency. |
.github/workflows/scan.yml |
Deleted; scan behavior moved into the verify job. |
.github/workflows/links.yml |
Deleted; link check moved into the verify job. |
docs/DISTRIBUTION.md |
Updates CI narrative to reflect consolidated checks and queue/cancel behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Moves the secret and workflow scan and the Markdown link check into the
verifyjob as the sharedactions/scanandactions/linkssteps (v1.2.0), and deletes the Scan and Links caller workflows..github/changes)mainpushVerification
actionlintandzizmor1.30.1 report nothing;vp run verifypasses.Notes
mainpush the scan audits workflows with Actionlint and Zizmor only when the pushed range changes them. Gitleaks stays off for this public repository, which relies on GitHub secret scanning and push protection.mainruns queue so each pushed range is scanned. Distribution says so.main:verifyand the semantic-release job, which publishes nothing for aci:commit.Written by an agent (Claude Code, Claude Opus 5.5)