Repository navigation
ci: scan and check links in the verify job - #93
Conversation
Replace the Scan and Links caller workflows with the putdotio/.github v1.2.0 scan and links actions as the last steps of verify. CI gains workflow_dispatch for a full-history scan, and only pull-request runs cancel when superseded.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
It alters CI security-scanning coverage and release-adjacent workflow wiring, so the disclosed security tradeoffs warrant final human review.
Review effort: Balanced
Findings: None
What changed in this PR
This PR consolidates CI security scanning and Markdown link checking into the existing verify job of .github/workflows/ci.yml, replacing the two standalone caller workflows (scan.yml, links.yml) with the shared actions/links and actions/scan composite actions (pinned to v1.2.0). It also restructures concurrency from the job level to the workflow level and adds a workflow_dispatch trigger so a full-history scan can be run manually.
I confirmed that putdotio/.github is public, so the scan action's Zizmor online audit works under the job's contents: read token, and that the action only performs workflow audits on push/workflow_dispatch (not on pull requests) per its plan.sh — consistent with the PR description. The behavior reductions (no PR-time workflow audit, no weekly scheduled scan, TruffleHog dropped) are intentional and disclosed in the PR's Risks section.
Changes:
- Add
actions/linksandactions/scansteps to theverifyjob; the scan step usesif: ${{ !cancelled() }}so it still runs after an earlier failure. - Move concurrency to the workflow level (
cancel-in-progressonly for pull requests) and add aworkflow_dispatchtrigger; deletescan.ymlandlinks.yml. - Update
docs/DISTRIBUTION.mdto describe the new inline links/scan steps.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds links/scan steps to verify, moves concurrency to workflow level, adds workflow_dispatch. |
.github/workflows/scan.yml |
Deleted; scanning now runs inline via the shared scan action. |
.github/workflows/links.yml |
Deleted; link checking now runs inline via the shared links action. |
docs/DISTRIBUTION.md |
Documents the new inline links and scan steps in the verify job. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
Moves the secret and workflow scan and the Markdown link check into the
verifyjob as the sharedactions/scanandactions/linkssteps (v1.2.0), and deletes the Scan and Links caller workflows..github/changes)mainpushRisks
mainpush the scan audits workflows with Actionlint and Zizmor only when the pushed range changes them. Gitleaks stays off for this public repository, which relies on GitHub secret scanning and push protection.mainruns queue so each pushed range is scanned.main:verifyand the semantic-release job, which publishes nothing for aci:commit.Verification
actionlintandzizmor1.30.1 report nothing;vp run verifypasses.Follow-Ups
None.
Written by an agent (Claude Code, Claude Opus 5.5)