Skip to content

ci: scan and check links in the verify job - #80

Merged
altaywtf merged 1 commit into
mainfrom
fix/verify-scan-links
Oct 5, 2026
Merged

altaywtf merged 1 commit into
mainfrom
fix/verify-scan-links

Conversation

@altaywtf

@altaywtf altaywtf commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Moves the secret and workflow scan and the Markdown link check into the verify job as the shared actions/scan and actions/links steps (v1.2.0), and deletes the Scan and Links caller workflows.

  • Jobs removed: 3–5 per pull request (Links, Gitleaks, TruffleHog, plus Actionlint and Zizmor when .github/ changes), 1 per main push (Links), and the weekly 4-job scan.
  • On a main push the scan audits workflows with Actionlint and Zizmor when the pushed range changes them; the new workflow_dispatch trigger scans full history. Gitleaks stays off for this public repository, which relies on GitHub secret scanning and push protection.
  • Concurrency moves to the workflow and cancels only superseded pull-request runs; main runs queue so each pushed range is scanned.
  • Local checks: actionlint and zizmor 1.30.1 report nothing; the links command with lychee 0.24.2 passes on this branch and exits 2 with a seeded missing file and anchor. Distribution describes the new steps.
  • Merging runs CI on main: verify and the semantic-release job, which publishes nothing for a ci: commit.

Written by an agent (Claude Code, Claude Opus 5.5)

Replace the Scan and Links caller workflows with the putdotio/.github v1.2.0 scan and links actions as the last steps of verify. CI gains workflow_dispatch for a full-history scan, and only pull-request runs cancel when superseded.
Copilot AI balanced review requested due to automatic review settings October 5, 2026 06:01
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@altaywtf
altaywtf merged commit 0188395 into main Oct 5, 2026
@altaywtf
altaywtf deleted the fix/verify-scan-links branch October 5, 2026 06:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

It alters the npm publishing pipeline's concurrency and gating and deletes the standalone Scan/Links workflows, which may be referenced as required status checks in branch protection that cannot be verified here.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

This PR consolidates the separate Scan and Links CI workflows into the existing verify job in ci.yml, using the shared actions/links and actions/scan composite actions (pinned to v1.2.0) from putdotio/.github. It reduces the number of per-PR jobs, drops the weekly scheduled scan, and reworks concurrency so that pull-request runs cancel superseded runs while main pushes queue (protecting in-flight releases). Documentation in DISTRIBUTION.md is updated to describe the new steps.

Changes:

  • Moved the Markdown link check and secret/workflow scan into the verify job as steps; added a workflow_dispatch trigger.
  • Replaced per-job concurrency groups with a single workflow-level group that only cancels in-progress runs for pull requests.
  • Deleted scan.yml and links.yml caller workflows and updated DISTRIBUTION.md.
File Description
.github/​workflows/​ci.yml Adds workflow_dispatch, workflow-level concurrency, and link/scan steps to the verify job; removes per-job concurrency blocks.
.github/​workflows/​scan.yml Deleted; scan behavior folded into the verify job (weekly schedule dropped).
.github/​workflows/​links.yml Deleted; link check folded into the verify job.
docs/​DISTRIBUTION.md Updates the distribution docs to describe the shared links/scan steps in verify.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/ci.yml
Comment on lines +45 to +46
- name: Check Markdown links
uses: putdotio/.github/.github/actions/links@c1830f7938b7dc98f085082e988d3c46437bb15c # v1.2.0
@putio-ci

putio-ci Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@putio-ci putio-ci Bot added the released label Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants