Repository navigation
ci: scan and check links in the verify job - #61
Conversation
Replace the Scan and Links caller workflows with the putdotio/.github v1.2.0 scan and links actions as the last steps of verify. CI gains workflow_dispatch for a full-history scan, and only pull-request runs cancel when superseded.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
It alters security-scanning cadence (drops the weekly scheduled scan) and release-pipeline concurrency while depending on external shared actions whose permission needs can't be verified here, warranting human sign-off.
Review effort: Balanced
Findings: None
What changed in this PR
This PR consolidates the repository's security/workflow scanning and Markdown link checking into the existing verify job of ci.yml, using the shared actions/links and actions/scan composite actions (v1.2.0) from putdotio/.github. It removes the two standalone caller workflows (scan.yml, links.yml), reducing the number of jobs per run, and reworks concurrency to a single workflow-level group that only cancels superseded pull-request runs while letting main pushes queue. The DISTRIBUTION.md doc is updated to describe the new behavior.
Changes:
- Add the shared
linksandscanactions as the final steps of theverifyjob (scan runs withif: ${{ !cancelled() }}); add aworkflow_dispatchtrigger. - Replace per-job concurrency blocks with one workflow-level
concurrencygroup that cancels in-progress runs only forpull_requestevents. - Delete
scan.ymlandlinks.ymland updatedocs/DISTRIBUTION.mdaccordingly.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Moves scan/links into verify, adds workflow_dispatch, and centralizes concurrency at the workflow level. |
.github/workflows/scan.yml |
Removed; its scheduled/PR/dispatch scan is replaced by the inline scan step. |
.github/workflows/links.yml |
Removed; its link check is replaced by the inline links step. |
docs/DISTRIBUTION.md |
Updates the distribution notes to reference the new shared links/scan steps. |
Observations (not blocking): The Scan step runs with if: ${{ !cancelled() }} so it always executes, while the Check Markdown links step has no guard and is therefore skipped whenever vp run verify fails. This asymmetry is plausibly intentional (security scan should always run), so I did not flag it as a defect. I also confirmed no stale references to the removed workflows remain (the README badge points only to ci.yml), and the new action refs follow the repo's SHA-pinning convention.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
🎉 This PR is included in version 3.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Moves the secret and workflow scan and the Markdown link check into the
verifyjob as the sharedactions/scanandactions/linkssteps (v1.2.0), and deletes the Scan and Links caller workflows..github/changes), 1 permainpush (Links), and the weekly 4-job scan.mainpush the scan audits workflows with Actionlint and Zizmor when the pushed range changes them; the newworkflow_dispatchtrigger scans full history. Gitleaks stays off for this public repository, which relies on GitHub secret scanning and push protection.mainruns queue so each pushed range is scanned.actionlintandzizmor1.30.1 report nothing; the links command with lychee 0.24.2 passes on this branch and exits 2 with a seeded missing file and anchor. Distribution describes the new steps.main:verifyand the semantic-release job, which publishes nothing for aci:commit.Written by an agent (Claude Code, Claude Opus 5.5)