Skip to content

content(cjs26): simplify CLI steps and clarify README link#19450

Merged
cnunciato merged 2 commits into
masterfrom
cnunciato/pr-changes
Jun 1, 2026
Merged

content(cjs26): simplify CLI steps and clarify README link#19450
cnunciato merged 2 commits into
masterfrom
cnunciato/pr-changes

Conversation

@cnunciato
Copy link
Copy Markdown
Contributor

Tweaks to the CascadiaJS 2026 event page (layouts/cjs26/list.html):

  • Trim the on-screen CLI steps to the essentials (drop the pulumi config set token line and pulumi up)
  • Tighten the laptop-password comment wording
  • Relabel the README link as QUESTIONS? README > so attendees know where to look

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@cnunciato cnunciato marked this pull request as ready for review June 1, 2026 01:20
@github-actions github-actions Bot added review:triaging Claude Triage is currently classifying the PR domain:infra PR touches workflows, scripts, infra, Makefile, or build config and removed review:triaging Claude Triage is currently classifying the PR labels Jun 1, 2026
@cnunciato cnunciato enabled auto-merge (squash) June 1, 2026 01:21
@cnunciato cnunciato requested a review from CamSoper June 1, 2026 01:21
@github-actions github-actions Bot added the review:in-progress Claude review is currently running label Jun 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

Pre-merge Review — Last updated 2026-06-01T01:22:17Z

Tip

Summary: Three-line copy tweak to the CascadiaJS '26 event landing template (layouts/cjs26/list.html): drops the pulumi config set cloudflare:apiToken … line from the on-screen CLI block, smooths the "Return here, enter…" comment to "Return here and enter…", and relabels the trailing GitHub link from README > to QUESTIONS? README >. The reader-blocking risk on a page like this would be a broken/misleading sequence that leaves an attendee stuck at the booth — so the relevant check is whether removing the apiToken step still produces a working pulumi up. The pulumi/cjs26 template is a real, public repo (verified via GitHub API), and Pulumi templates commonly collect provider credentials interactively during pulumi new, so this is consistent with the simplification framing in the title; no other claims surface in the diff. Verification pass (1/1 claim verified) ran; cross-sibling, frontmatter, code-execution, code-examples, and editorial-balance passes were not applicable.

Review confidence:

Dimension Level Notes
mechanics HIGH
facts MEDIUM The removed pulumi config set cloudflare:apiToken step wasn't a verifier-extractable claim, so the assumption that the template now collects this interactively during pulumi new is based on framing and Pulumi convention, not a confirmed read of the template's config schema.
Investigation log
  • Cross-sibling reads: not run (not in a templated section)
  • External claim verification: 1 of 1 claims verified (0 unverifiable, 0 contradicted) · 4 specialists (numerical, cross-reference, capability, framing); 0 cross-specialist corroborations · routed: 0 inline, 1 Pass 1, 0 Pass 2, 0 Pass 3.
  • Cited-claim spot-checks: not run (no cited claims)
  • Frontmatter sweep: not run (no frontmatter in diff)
  • Temporal-trigger sweep: ran (recency words present in diff; spot-check in-review)
  • Code execution: not run (no static/programs/ change)
  • Code-examples checks: not run (no fenced code blocks in content files)
  • Editorial-balance pass: not run (not under content/blog/)
🚨 Outstanding ⚠️ Low-confidence 💡 Pre-existing ✅ Resolved
0 0 0 0

🔍 Verification trail

1 claims extracted · 1 verified · 0 unverifiable · 0 contradicted
  • L186 in layouts/cjs26/list.html "QUESTIONS? README >" → ✅ verified (evidence: The GitHub API confirms pulumi/cjs26 is a real, public repository at https://github.com/pulumi/cjs26, described as "A Pulumi template that deploys an Astro app to Cloudflare Workers." The URL used in the anchor tag is valid and resolve…; source: gh api repos/pulumi/cjs26)

🚨 Outstanding in this PR

No outstanding findings in this PR.

⚠️ Low-confidence

No low-confidence findings.

💡 Pre-existing issues in touched files (optional)

No pre-existing issues in touched files.

✅ Resolved since last review

No items resolved since the last review.

📜 Review history

  • 2026-06-01T01:22:17Z — Three-line copy tweak to the cjs26 event template; GitHub repo URL verified, no blockers. (8364e59)

Need a re-review? Want to dispute a finding? Mention @claude and include #update-review.
(For ad-hoc questions or fixes, just @claude — no hashtag.)

@github-actions github-actions Bot added review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:in-progress Claude review is currently running labels Jun 1, 2026
@pulumi-bot
Copy link
Copy Markdown
Collaborator

pulumi-bot commented Jun 1, 2026

@pulumi-bot
Copy link
Copy Markdown
Collaborator

pulumi-bot commented Jun 1, 2026

Lighthouse Performance Report

Commit: 8364e59 | Metric definitions

Page Device Score FCP LCP TBT CLS SI
Homepage Mobile 🔴 46 3.0s 4.2s 1675ms 0.072 7.7s
Homepage Desktop 🟡 78 0.8s 1.1s 296ms 0.036 2.8s
Install Pulumi Mobile 🔴 36 5.3s 7.8s 244ms 0.378 8.0s
Install Pulumi Desktop 🟡 82 1.3s 1.8s 22ms 0.013 3.0s
AWS Get Started Mobile 🟡 56 5.1s 7.8s 268ms 0.076 5.1s
AWS Get Started Desktop 🟡 83 1.3s 1.7s 22ms 0.020 3.0s

@cnunciato cnunciato merged commit 20ac18a into master Jun 1, 2026
14 checks passed
@cnunciato cnunciato deleted the cnunciato/pr-changes branch June 1, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain:infra PR touches workflows, scripts, infra, Makefile, or build config review:no-blockers Claude review completed cleanly; outstanding is empty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants