Skip to content

Migrate releases templates to shared typography utilities#19399

Open
jeffmerrick wants to merge 1 commit into
masterfrom
jeffmerrick/tweak-releases-font-size
Open

Migrate releases templates to shared typography utilities#19399
jeffmerrick wants to merge 1 commit into
masterfrom
jeffmerrick/tweak-releases-font-size

Conversation

@jeffmerrick
Copy link
Copy Markdown
Contributor

@jeffmerrick jeffmerrick commented May 26, 2026

Generated description of changes:

Replaces ad-hoc text/heading class lists across the releases templates (hero-card, section, intro-toc-row, card-text-block, release-item, and the releases list layout) with the heading-*, body-*, and font-overline @utility classes introduced in #19289, so the releases pages pick up the shared type scale. Margin overrides (m-0!) are added where a heading utility would otherwise inject an unwanted mb-2.

Replaces ad-hoc text/heading class lists in the releases templates with
the heading-*, body-*, and font-overline @Utility classes from the
shared type scale.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions github-actions Bot added the review:triaging Claude Triage is currently classifying the PR label May 26, 2026
@jeffmerrick jeffmerrick requested a review from cnunciato May 26, 2026 22:01
@github-actions github-actions Bot added domain:infra PR touches workflows, scripts, infra, Makefile, or build config review:in-progress Claude review is currently running and removed review:triaging Claude Triage is currently classifying the PR labels May 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Pre-merge Review — Last updated 2026-05-26T22:02:31Z

Tip

Summary: Infra/template refactor: swaps ad-hoc Tailwind class strings (text-xl md:text-2xl …, font-mono text-sm tracking-wider uppercase, etc.) for shared @utility classes (heading-xl/heading-1/heading-2/heading-3, body-base/body-lg, font-overline) across six layouts/releases/ partials. All six referenced utilities are defined in theme/src/scss/_utilities-shared.scss, so the migration won't produce undefined classes; m-0! is added where needed to suppress the mb-2 that the heading utilities introduce. No content, frontmatter, or routing changes — risk is purely visual, and at breakpoint boundaries the new scale is intentionally different from the old class lists (e.g., the hero <h1> drops lg:text-6xl, release-item <h2> jumps from text-3xl to text-4xl at the base size). Worth spot-checking /releases/ and a release detail page in a browser before merging.

Review confidence:

Dimension Level Notes
mechanics HIGH All migrated utilities exist; m-0! correctly suppresses utility-introduced margins.
facts HIGH No factual claims in this diff.
Investigation log
  • Cross-sibling reads: not run (not in a templated section)
  • External claim verification: not run (no claims in this diff)
  • Cited-claim spot-checks: not run (no cited claims)
  • Frontmatter sweep: not run (no frontmatter in diff)
  • Temporal-trigger sweep: not run (no trigger words)
  • Code execution: not run (no static/programs/ change)
  • Code-examples checks: not run (no fenced code blocks in content files)
  • Editorial-balance pass: not run (not under content/blog/)
🚨 Outstanding ⚠️ Low-confidence 💡 Pre-existing ✅ Resolved
0 0 0 0

🔍 Verification trail

No verifiable claims extracted from this diff.

🚨 Outstanding in this PR

No outstanding findings in this PR.

⚠️ Low-confidence

No low-confidence findings.

💡 Pre-existing issues in touched files (optional)

No pre-existing issues in touched files.

✅ Resolved since last review

No items resolved since the last review.

📜 Review history

  • 2026-05-26T22:02:31Z — Typography-utility migration across six layouts/releases/ partials; all referenced utilities resolve in _utilities-shared.scss, no blockers. (07a7ef4)

Need a re-review? Want to dispute a finding? Mention @claude and include #update-review.
(For ad-hoc questions or fixes, just @claude — no hashtag.)

@github-actions github-actions Bot added review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:in-progress Claude review is currently running labels May 26, 2026
@pulumi-bot
Copy link
Copy Markdown
Collaborator

@pulumi-bot
Copy link
Copy Markdown
Collaborator

Lighthouse Performance Report

Commit: 07a7ef4 | Metric definitions

Page Device Score FCP LCP TBT CLS SI
Homepage Mobile 🔴 36 3.1s 5.8s 2133ms 0.072 7.9s
Homepage Desktop 🟡 78 0.8s 1.1s 301ms 0.059 2.9s
Install Pulumi Mobile 🟡 52 5.3s 8.7s 292ms 0.027 8.2s
Install Pulumi Desktop 🟡 80 1.3s 2.0s 22ms 0.001 3.0s
AWS Get Started Mobile 🟡 54 5.1s 8.4s 216ms 0.076 8.0s
AWS Get Started Desktop 🟡 83 1.3s 1.7s 24ms 0.020 3.0s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain:infra PR touches workflows, scripts, infra, Makefile, or build config review:no-blockers Claude review completed cleanly; outstanding is empty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants