Persist CookiePolicy at session level #7130
Open
+30
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7122
Essentially a semantic cherry-pick of the delta in #4042.
These changes persist the policy on the session cookie-jar instead of discarding it by doing a merge against an empty
RequestsCookieJar.#4042 mentions:
Not too sure why, as long as
CookieJaris a superclass the underlying policy would be respected._copy_cookie_jarwould shallow copy the jar along with it's policy in the case of a nonRequestsCookieJar.Nevertheless, changes are backwards complatible.