Fix: Preserve custom CookiePolicy in Session.prepare_request #7129
+3,079
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where custom cookie policies set on a Session's cookie jar were not being preserved during request preparation.
Details
In
Session.prepare_request(), when merging cookies from the session and request, the code was creating a newRequestsCookieJar()without preserving the cookie policy from the session's cookie jar. This meant that any custom cookie policy (likeMyCustomCookiePolicyin issue #7122) would be lost during request preparation.Fix
Modified the cookie merging logic to check if the session's cookies are a
RequestsCookieJarand, if so, preserve the cookie policy by copying it to the new jar usingset_policy().Testing
The fix has been tested to ensure:
Session.prepare_requestFixes #7122