Skip to content

feat(knowledge): typed memory schema — kind, subject, review_state, expires_at (#3072) - #3206

Closed
mabry1985 wants to merge 1 commit into
mainfrom
feat/3072-typed-memory-schema-v2
Closed

feat(knowledge): typed memory schema — kind, subject, review_state, expires_at (#3072)#3206
mabry1985 wants to merge 1 commit into
mainfrom
feat/3072-typed-memory-schema-v2

Conversation

@mabry1985

Copy link
Copy Markdown
Member

Summary

  • Adds 4 typed memory columns (memory_kind, subject, review_state, expires_at) to the knowledge store via additive SQLite migration — no delivery behavior changes
  • Adds memory_kind and review_state filter parameters to search(), list_chunks(), and corresponding memory tools (memory_recall, memory_list)
  • Updates memory_ingest tool to accept memory_kind and subject, and stamps session namespace on writes

Tracks #3072. Additive migration: all columns are nullable with None defaults; existing callers are unaffected. The Chunk dataclass, as_dict(), and all tool output formats are extended — never broken.

Test plan

  • ruff check . passes
  • python -m pytest tests/test_typed_memory.py -q — 14 tests covering migration, round-trip, filters, backward compat
  • python -m pytest tests/test_knowledge_lifecycle.py -q — existing lifecycle tests still pass (37 total)
  • CI gates (ruff, lint-imports, full pytest)

🤖 Generated with Claude Code

https://claude.ai/code/session_01WEMxBi71vjtmmmziFCMcby

…expires_at (#3072)

Additive migration adds memory_kind, subject, review_state, and expires_at
columns to the chunks table. Search and list gain filter parameters for
memory_kind and review_state. memory_ingest/recall/list tools surface the
new fields. No delivery behavior changes -- all columns are nullable,
existing callers are unaffected.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WEMxBi71vjtmmmziFCMcby
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mabry1985

Copy link
Copy Markdown
Member Author

Duplicate — work consolidated on #3205.

@mabry1985 mabry1985 closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant