feat(knowledge): typed memory schema — kind, subject, review_state, expires_at (#3072) - #3206
Closed
mabry1985 wants to merge 1 commit into
Closed
feat(knowledge): typed memory schema — kind, subject, review_state, expires_at (#3072)#3206mabry1985 wants to merge 1 commit into
mabry1985 wants to merge 1 commit into
Conversation
…expires_at (#3072) Additive migration adds memory_kind, subject, review_state, and expires_at columns to the chunks table. Search and list gain filter parameters for memory_kind and review_state. memory_ingest/recall/list tools surface the new fields. No delivery behavior changes -- all columns are nullable, existing callers are unaffected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WEMxBi71vjtmmmziFCMcby
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
Duplicate — work consolidated on #3205. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory_kind,subject,review_state,expires_at) to the knowledge store via additive SQLite migration — no delivery behavior changesmemory_kindandreview_statefilter parameters tosearch(),list_chunks(), and corresponding memory tools (memory_recall,memory_list)memory_ingesttool to acceptmemory_kindandsubject, and stamps session namespace on writesTracks #3072. Additive migration: all columns are nullable with
Nonedefaults; existing callers are unaffected. TheChunkdataclass,as_dict(), and all tool output formats are extended — never broken.Test plan
ruff check .passespython -m pytest tests/test_typed_memory.py -q— 14 tests covering migration, round-trip, filters, backward compatpython -m pytest tests/test_knowledge_lifecycle.py -q— existing lifecycle tests still pass (37 total)🤖 Generated with Claude Code
https://claude.ai/code/session_01WEMxBi71vjtmmmziFCMcby