Repository navigation
Conversation
Member
|
Closing this. Putting env() in the default DSL helpers would let a template read the process environment, including API keys, and send those values out in a request. I do not want that in the default set. Happy to look again if it stays out of the helpers a template can call. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192
Adds an
env(key, optionalDefault)helper that returns the value of anenvironment variable, or the optional default when it is not set.
Testing:
go test -run TestEnvDSLFunction -vpasses.Note: TestDslExpressions has 4 pre-existing failures (gzip, zlib, zip,
deflate) on Go 1.27.3; they also fail on main without this change,
likely due to compress/flate output changes in newer Go versions.
Security note: since templates may come from third parties, nuclei may
want to gate this behind an opt-in flag (similar to
-env-vars) to avoidleaking secrets from the scanning machine.