Update to github.com/mtrmac/gpgme v0.1.2#369
Open
mtrmac wants to merge 2 commits intoprojectatomic:docker-1.13.1-rhelfrom
Open
Update to github.com/mtrmac/gpgme v0.1.2#369mtrmac wants to merge 2 commits intoprojectatomic:docker-1.13.1-rhelfrom
mtrmac wants to merge 2 commits intoprojectatomic:docker-1.13.1-rhelfrom
Conversation
This seems to be a mistaken commit of an intermediate build state in the old times when vendoring was used via a GOPATH at vendor/src/... Signed-off-by: Miloslav Trmač <[email protected]>
This fixes CVE-2020-8945 by incorporating proglottis/gpgme#23 . Other changes included by the rebase: - Support for gpgme_off_t (~no-op with the RHEL 7 GPGME 1.3.2) - Wrapping a few more GPGME functions (irrelevant if we don't call them) - Better error reporting in Context.GetKey Given how invasive the CVE fix is (affecting basically all binding code), it seems safer to just update the package (and be verifiably equivalent with upstream) than to backport and try to back out the few other changes. Performed by updating vendor.conf, and $ mkdir -p _build/src/github.com/docker $ ln -s $(pwd) _build/src/github.com/docker/docker $ GOPATH=$(pwd)/_build:$GOPATH vndr github.com/mtrmac/gpgme Signed-off-by: Miloslav Trmač <[email protected]>
Author
|
(Warning: I didn’t test one bit whether the result works.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
This fixes CVE-2020-8945 by incorporating proglottis/gpgme#23 .
Other changes included by the rebase:
Given how invasive the CVE fix is (affecting basically all binding code), it seems safer to just update the package (and be verifiably equivalent with upstream) than to backport and try to back out the few other changes.
- How I did it
Performed by updating vendor.conf, and
- How to verify it
I have only checked that it compiles, via
- Description for the changelog
Incorporated a fix for CVE-2020-8945 .