Fix Android TLS issue caused by matrix SDK change#957
Merged
Conversation
On Android, matrix-sdk's reqwest config now defaults to `rustls-platform-verifier`, which panics by default because it wasn't being initialized. Instead we now just directly use Mozilla's `webpki` roots directly (Android only). This commit also dedups the client builder stuff so that we don't mess it up across different callsites (first-time login vs. session restore). Another important change: use the platform-canonical cache dir as the location for the SDK's event and media caches. This allows the user to clear them easily using OS-provided mechanisms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android, matrix-sdk's reqwest config now defaults to
rustls-platform-verifier, which panics by default because it wasn't being initialized. Instead we now just directly use Mozilla'swebpkiroots directly (Android only).This commit also dedups the client builder stuff so that we don't mess it up across different callsites (first-time login vs. session restore).
Another important change: use the platform-canonical cache dir as the location for the SDK's event and media caches. This allows the user to clear them easily using OS-provided mechanisms.