CI: Add Robrix build CI configuration.#522
Conversation
|
Do we need to create a new develop branch for code merge and review. The latest Robrix is built weekly through the main branch, and the whole build will take a lot of build time if we do frequent related builds directly on main. At the same time it would be better to release the latest Robrix. Note: Currently we don't have a CI configuration for Release. |
I don't understand what this means. The CI should be run on new PRs as a prerequisite check before a PR is allowed to be merged in.
For now, we don't need to automatically build Robrix every X days or something. We should just have the CI infrastructure for doing so, such that I can roll out builds whenever we want to build a new release.
You mean for building artifacts for a new github release? That's fine, you can add it next. Moly has already done part of that, so you can borrow their implementation. |
kevinaboos
left a comment
There was a problem hiding this comment.
Thanks!
Here are a few changes that pertain to multiple CI jobs:
- Please remove the
--all-targetsand--releaseargs from each build. We definitely do not want to build in--releasemode; in fact, we want the opposite, as we just want the fastest possible builds. - We are now tracking the
devbranch of makepad, notrik. - For all of the "Verify Android/iOS build artifacts" jobs, the
findcommand doesn't really do what you want it to do. That sequence of commands (and the windowsGet-ChildItemcommand) should end with returning an error if those files don't exist, butfinddoesn't do that.- Also, the
find || echo "error"sequence doesn't work on macOS.
- Also, the
- The android builds for Robrix don't need
--full-ndkto be installed, you can remove that. - We should skip all CI jobs if the PR is in draft mode:
if: github.event.pull_request.draft == false
4bbb723 to
617466d
Compare
kevinaboos
left a comment
There was a problem hiding this comment.
Looks good, just two small things:
- please address the exclude paths (see my latest comment)
- please fix the README here based on your comment about not needing the full-ndk arg.
- Rename build.yml to builds.yml for clarity - Add ignore patterns for markdown and license files in CI triggers - Remove --full-ndk flag from Android toolchain installation
No longer needed
PR content
Add a matrix of build passes for the 3 main host platforms for the 5 main target platforms
Build Matrix Coverage
Related PR