fix: throttle worker heartbeat noise and align sidecar state#11
Open
kbentonferguson wants to merge 1 commit into
Open
fix: throttle worker heartbeat noise and align sidecar state#11kbentonferguson wants to merge 1 commit into
kbentonferguson wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
poll_seconds=0.1loop--heartbeat-secondssupport while preserving non-default--poll-secondsas the compatibility fallbackPUPPETMASTER_STATE_DIRaround inline workers so adapter sidecars land under the owning store rootWhy
Puppetmaster workers were renewing leases and emitting heartbeat/save events every
0.1s, producing thousands of events for ordinary runs and making logs/status debugging noisy. Slowing the default heartbeat path cuts that event churn while preserving lease safety and existing callers that tuned--poll-seconds.Inline worker mode also did not export the resolved store root through
PUPPETMASTER_STATE_DIR, so adapter sidecar logs could be written under the wrong project state dir when the parent environment pointed elsewhere.Tests
python3 -m pytest tests/test_puppetmaster.py -q -k 'heartbeat or inline_workers_scope_state_dir'env -u CODEX_COMMAND -u CODEX_CI -u CODEX_HOME -u CODEX_PATH -u CODEX_THREAD_ID python3 -m pytest tests/test_puppetmaster.py -qgit diff --checkjob_391b13303b3b: no blocking issuejob_08b8c258fd9e: no blocking issuejob_d5fb9427fc66: surfaced compatibility/short-lease findings addressed in this PR