fix: background(image) support in WEBGL #8333
Open
+35
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In WEBGL mode, calling background(image) was forwarded directly to the renderer and treated as a color value, which caused an error. This change intercepts image-like arguments in
p5.prototype.background, clears the WebGL buffers, and draws the image screen-aligned using image().A regression unit test has been added to ensure background(image) does not
throw in WEBGL mode.
Resolves #7917
PR Checklist
npm run lintpasses