Use a pattern-based group for the uv ecosystem - #397
Merged
Conversation
The uv group added in #395 used "dependency-type", which dependabot only supports inside "groups" for bundler, composer, mix, maven, npm, and pip. It is not valid for uv, and an unsupported key makes the whole config invalid, which stops every ecosystem's updates silently rather than reporting a per-block error. Replaced the python-runtime / python-dev split with a single "python" group matching all patterns, consistent with the github-actions and gomod groups. Minor and patch bumps for sdk-python now collapse into one PR, and runtime bumps such as pydantic or httpx land in that same PR rather than a separate one. Majors are still excluded from the group and arrive individually, so the higher-risk upgrades stay reviewable on their own. The npm group is untouched: npm does support dependency-type.
|
docfacts: no documented claims affected. |
 |
Member
Author
|
@greptile review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
uvgroup added in #395 useddependency-type, which dependabot supports insidegroupsonly forbundler,composer,mix,maven,npm, andpip. It is not valid foruv.This matters more than a normal config typo: an unsupported key invalidates the whole
dependabot.yml, and dependabot then stops updates for every ecosystem rather than reporting a per-block error. So #395, which was meant to reduce PR noise, would have stopped dependency updates outright.Source: Dependabot options reference,
groups.What changed
The
python-runtime/python-devsplit is replaced with a singlepythongroup matching all patterns, consistent with theactionsandgo-modulesgroups.Tradeoff worth naming:
patternscannot express the runtime-vs-tooling split thatdependency-typewould have, so a runtime bump such aspydanticorhttpxnow lands in the same PR asruffandpytest. Majors are still excluded from the group and arrive as individual PRs, which is where the upgrade risk actually concentrates. If the runtime deps do need isolating later, the way to do it is an explicitexclude-patternslist on the group, at the cost of that list drifting frompyproject.toml.The
npmgroup is untouched, sincenpmdoes supportdependency-type.Test plan
groups.dependency-typenpm/dev-dependenciesis the only one usingdependency-typeandnpmis on the supported list; the other three use onlypatternsandupdate-types, which are valid for all ecosystems.github/dependabot.ymlparses as valid YAMLConfig-only change, no SDK code touched. Full local suite was run on this tree at #395 and nothing outside
.github/has changed since.After merge, the repo's Insights > Dependency graph > Dependabot tab should show no config error. That surface is the real confirmation, since the failure mode here is silent.