refactor: ES6 classes #130
Merged
+49
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
commented
Dec 15, 2025
| @@ -1,5 +1,5 @@ | |||
| import { h } from 'preact'; | |||
| import registerElement from '../../src/index'; | |||
| import registerElement from '../../src/index.js'; | |||
|
Size Change: -34 B (-3.21%) Total Size: 1.03 kB
|
rschristian
force-pushed
the
refactor/es6-classes
branch
4 times, most recently
from
e173fc3 to
ad5386f
Compare
rschristian
commented
Dec 18, 2025
Comment on lines
60
to
+62
| PreactElement.observedAttributes = propNames; | ||
|
|
||
| if (Component.formAssociated) { | ||
| PreactElement.formAssociated = true; | ||
| } | ||
| PreactElement.formAssociated = Component.formAssociated || false; |
Member
Author
There was a problem hiding this comment.
Static class properties are ES2022 and compress slightly worse. This will do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.