Repository navigation
Conversation
Covers the jobs half of the background tasks spike: a bounded queue, a worker pool, a per-job timeout, and cancellation. Probes are left to a separate proposal. What? and Why? only, per the proposal process; How? follows once the direction is agreed. Signed-off-by: Charlie Doern <cdoern@redhat.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes a bounded job queue in core, with a worker pool, a per-job timeout, and cancellation, so that a filter can enqueue work which outlives the request that created it. It covers the jobs half of praxis-proxy/praxis#807 and leaves probes to a separate proposal, since the two share nothing beyond supervision.
The research behind it narrowed the scope considerably.
FilteredSubrequestExecutoralready runs a request through a real filter pipeline with no client connection attached, and there is a passing test driving exactly that against a backend today. What is missing is not an execution engine but a queue, a worker pool, and a lifetime for them.Per the process this first PR contains only What? and Why?. The How? section listing the implementing PRs will follow once the direction is agreed.
The section worth the most scrutiny is the relationship to ENH #1042. That proposal cancels background work when its pipeline drops, which is what a token refresher wants but would cancel every in-flight job on a config reload. I have argued that jobs need process lifetime instead, and listed @aslakknutsen as a stakeholder for that reason.