Skip to content

Services - #23

Closed
alexsnaps wants to merge 4 commits into
praxis-proxy:mainfrom
alexsnaps:services
Closed

Services#23
alexsnaps wants to merge 4 commits into
praxis-proxy:mainfrom
alexsnaps:services

Conversation

@alexsnaps

@alexsnaps alexsnaps commented Oct 8, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Related issue

Checklist

  • Issue link is in proposal frontmatter
  • Authors and stakeholders listed
  • Repos list includes all affected repositories
  • Graduation criteria are specific and verifiable
  • First PR contains only What? and Why? (no How?)

@alexsnaps
svn import
937c710 
Signed-off-by: Alex Snaps <alex@wcgw.dev>
@alexsnaps
first pass
f9628c6 
Signed-off-by: Alex Snaps <alex@wcgw.dev>
@alexsnaps
second pass
371afe3 
Signed-off-by: Alex Snaps <alex@wcgw.dev>
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: praxis-proxy/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 8d073ac6-8a5a-42c0-b0fa-53b0939c2c7d
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

alexsnaps
alexsnaps commented Oct 8, 2026
View reviewed changes
Comment thread proposals/01375_service-registry.md
Comment thread proposals/01375_service-registry.md
Comment on lines +493 to +497
7. **Service config change triggers filter chain rebuild.** If a
service's config changes on reload, the service is stopped and
restarted, and all filter chains that reference it are rebuilt.
Filter authors can assume a stable service config for the
lifetime of their handle.

@alexsnaps alexsnaps Oct 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if I wouldn't want to pass (move) the previous service, if any (Option<S>) back in or something. e.g. you might want to change a max_memory setting on a cache without having to lose all cached entries or having to flush them to disk, only to reload them. i.e. a case that'd call for ManagedService::reconfigure(&mut self) but I really dislike that 😭

@alexsnaps
fix(types): Properly isolate ManagedService from consumers
912c600 
Signed-off-by: Alex Snaps <alex@wcgw.dev>
@alexsnaps
alexsnaps requested a review from a team October 16, 2026 14:18
@alexsnaps
alexsnaps marked this pull request as ready for review October 16, 2026 14:18
@alexsnaps
alexsnaps requested a review from a team as a code owner October 16, 2026 14:18
@praxis-bot-app

praxis-bot-app Bot commented Oct 16, 2026

Copy link
Copy Markdown

Proposal validation failed:

  • proposals/01375_service-registry.md: new proposals must not include the ## How? section in the first PR. Submit What? and Why? first; add How? in a follow-up.

See proposal process for requirements.

@alexsnaps

alexsnaps commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

Asking for a more formal review now I guess.

@alexsnaps alexsnaps added the area/core Core config, validation, and runtime label Oct 16, 2026
redhat-chai-bot
redhat-chai-bot reviewed Oct 22, 2026
View reviewed changes

@redhat-chai-bot redhat-chai-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial Review — Services

Enhancement proposal for service composition. CI has proposal-check failure.

Verdict: Address CI proposal-check before merge.

AI-generated. Review for accuracy.

@alexsnaps alexsnaps closed this Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@redhat-chai-bot redhat-chai-bot redhat-chai-bot left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/core Core config, validation, and runtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexsnaps @redhat-chai-bot