Use discrete adjustment control in slider velocity adjustment popover in top timeline#38183
Merged
Merged
Conversation
… in top timeline Continuation of ppy#38140. Applied in the slider velocity adjustment popover first because it is easier to do so. The right toolbox will come at the end of this series of queued changes. The reason why `SliderVelocityAdjustmentControl` is a separate entity is twofold: - I aim to use it directly both in the timeline popover *and* the right toolbox. - It will receive a preset control that allows mappers to add and remove their own preset slider velocity values.
bdach
added
area:editor
type/cosmetic
github-project-automation
Bot
moved this from Pending Review
to Done
in osu! team task tracker
0xAlexisSys
pushed a commit
to 0xAlexisSys/osu
that referenced
this pull request
Jun 30, 2026
… in top timeline (ppy#38183) https://github.com/user-attachments/assets/822d62a0-e51e-4227-807e-280e8957364c --- Continuation of ppy#38140. Applied in the slider velocity adjustment popover first because it is easier to do so. The right toolbox will come at the end of this series of queued changes. The reason why `SliderVelocityAdjustmentControl` is a separate entity is twofold: - I aim to use it directly both in the timeline popover *and* the right toolbox. - It will receive a preset control that allows mappers to add and remove their own preset slider velocity values.
0xAlexisSys
pushed a commit
to 0xAlexisSys/osu
that referenced
this pull request
Jun 30, 2026
… in top timeline (ppy#38183) https://github.com/user-attachments/assets/822d62a0-e51e-4227-807e-280e8957364c --- Continuation of ppy#38140. Applied in the slider velocity adjustment popover first because it is easier to do so. The right toolbox will come at the end of this series of queued changes. The reason why `SliderVelocityAdjustmentControl` is a separate entity is twofold: - I aim to use it directly both in the timeline popover *and* the right toolbox. - It will receive a preset control that allows mappers to add and remove their own preset slider velocity values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-06-29.at.09.06.41.mov
Continuation of #38140.
Applied in the slider velocity adjustment popover first because it is easier to do so. The right toolbox will come at the end of this series of queued changes.
The reason why
SliderVelocityAdjustmentControlis a separate entity is twofold: